Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 61833005: Mojo: modifications to service source (Closed)

Created:
7 years, 1 month ago by DaveMoore
Modified:
7 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: modifications to service source - Move Params class to anonymous namespace - Roll private class definitions into declarations - Remove unnecessary namespace references BUG=None TEST=None R=darin@chromium.org, darin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -59 lines) Patch
M mojo/public/bindings/sample/generated/sample_service.cc View 10 chunks +46 lines, -59 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
DaveMoore
7 years, 1 month ago (2013-11-06 22:56:46 UTC) #1
darin (slow to review)
OK, LGTM
7 years, 1 month ago (2013-11-06 23:06:12 UTC) #2
DaveMoore
7 years, 1 month ago (2013-11-06 23:08:13 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r233410 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698