Subzero: Move to C++11 static_assert().

Subzero: Move to C++11 static_assert().

BUG= none
R=jvoung@chromium.org, kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=fac55170422106521e025461424e415acbbbbebc

[Jim Stichnoth, 2014-10-01 16:03:45]

stichnot@chromium.org changed reviewers:
+ jvoung@chromium.org, kschimpf@google.com

[jvoung (off chromium), 2014-10-01 17:32:53]

lgtm

https://codereview.chromium.org/618313003/diff/1/src/IceIntrinsics.cpp
File src/IceIntrinsics.cpp (right):

https://codereview.chromium.org/618313003/diff/1/src/IceIntrinsics.cpp#newcode29
src/IceIntrinsics.cpp:29: static_assert(sizeof(Intrinsics::IntrinsicInfo) == 4,
Does static_assert() need to be wrapped in a unused function, or can it now be
just in the namespace { } (or the IceIntrinsics class)?

[Karl, 2014-10-01 19:36:17]

lgtm

[Jim Stichnoth, 2014-10-01 20:02:41]

https://codereview.chromium.org/618313003/diff/1/src/IceIntrinsics.cpp
File src/IceIntrinsics.cpp (right):

https://codereview.chromium.org/618313003/diff/1/src/IceIntrinsics.cpp#newcode29
src/IceIntrinsics.cpp:29: static_assert(sizeof(Intrinsics::IntrinsicInfo) == 4,
On 2014/10/01 17:32:53, jvoung wrote:
> Does static_assert() need to be wrapped in a unused function, or can it now be
> just in the namespace { } (or the IceIntrinsics class)?

Good point.  I removed the dummy function wrappers in all 3 files.

Unfortunately, "make format-diff" was a bit shy about fixing the indentation
inside the various namespaces, so I ran clang-format-3.4 on the entirety of two
of the files, so there are now a bunch of whitespace diffs.

[Jim Stichnoth, 2014-10-01 20:06:33]

Committed patchset #2 (id:20001) manually as
fac55170422106521e025461424e415acbbbbebc (presubmit successful).