Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 618303002: Remove DEPRECATED_beginRecording(). (Closed)

Created:
6 years, 2 months ago by mtklein_C
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove DEPRECATED_beginRecording(). This removes: 1) ability to record old pictures with SkPictureRecorder; 2) a couple tests specific to the old backend. The functionality of DEPRECATED_beginRecording() now lives in (private) SkPicture::Backport(), which is the only place we need it now. BUG=skia: TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/8e12656096fceeed8b3cc4284d57dea04893b455

Patch Set 1 #

Patch Set 2 : Remove DEPRECATED_ and EXPERIMENTAL_beginRecording(). #

Patch Set 3 : New debug-only code. #

Patch Set 4 : A little more #

Patch Set 5 : just one offset #

Patch Set 6 : fix up benches #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -191 lines) Patch
M bench/PictureRecordBench.cpp View 1 2 3 4 5 3 chunks +6 lines, -4 lines 0 comments Download
M include/core/SkPicture.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M include/core/SkPictureRecorder.h View 1 2 chunks +2 lines, -19 lines 0 comments Download
M src/core/SkPicture.cpp View 1 3 chunks +8 lines, -8 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 2 3 4 23 chunks +25 lines, -21 lines 0 comments Download
M src/core/SkPictureRecorder.cpp View 1 3 chunks +3 lines, -49 lines 0 comments Download
M tests/CanvasTest.cpp View 5 chunks +1 line, -40 lines 0 comments Download
M tests/PictureTest.cpp View 12 chunks +29 lines, -49 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
mtklein
6 years, 2 months ago (2014-10-01 14:38:18 UTC) #2
robertphillips
lgtm
6 years, 2 months ago (2014-10-01 14:50:58 UTC) #3
mtklein
Forgot to mention: needs an include/ stamp to remove public API.
6 years, 2 months ago (2014-10-01 14:53:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618303002/80001
6 years, 2 months ago (2014-10-01 14:56:53 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.120:10117/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Debug-Trybot/builds/944)
6 years, 2 months ago (2014-10-01 15:11:00 UTC) #8
mtklein
PictureRecordBench.cpp was exploiting some undefined behavior, calling endRecording() before calling beginRecording(). Fixed that up. PTAL.
6 years, 2 months ago (2014-10-01 15:20:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618303002/100001
6 years, 2 months ago (2014-10-01 15:21:12 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618303002/100001
6 years, 2 months ago (2014-10-01 15:51:19 UTC) #16
robertphillips
lgtm on new patch
6 years, 2 months ago (2014-10-01 16:11:49 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618303002/100001
6 years, 2 months ago (2014-10-01 16:24:29 UTC) #20
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 16:29:43 UTC) #21
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as 8e12656096fceeed8b3cc4284d57dea04893b455

Powered by Google App Engine
This is Rietveld 408576698