Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Unified Diff: ui/events/x/device_data_manager_x11.cc

Issue 618283003: Adds special support to the device manager for keyboards devices. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase to master. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/x/device_data_manager_x11.h ('k') | ui/events/x/device_data_manager_x11_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/x/device_data_manager_x11.cc
diff --git a/ui/events/x/device_data_manager_x11.cc b/ui/events/x/device_data_manager_x11.cc
index 795cc44be7b4af79def8f0bbfce52cdd02ea6664..4b29631d1a4927ca41d04f6f8a4053b39846f3e9 100644
--- a/ui/events/x/device_data_manager_x11.cc
+++ b/ui/events/x/device_data_manager_x11.cc
@@ -8,11 +8,14 @@
#include <X11/extensions/XInput2.h>
#include <X11/Xlib.h>
+#include <utility>
+
#include "base/logging.h"
#include "base/memory/singleton.h"
#include "base/sys_info.h"
#include "ui/events/event_constants.h"
#include "ui/events/event_switches.h"
+#include "ui/events/keyboard_device.h"
#include "ui/events/keycodes/keyboard_code_conversion_x.h"
#include "ui/events/x/device_list_cache_x.h"
#include "ui/events/x/touch_factory_x11.h"
@@ -106,6 +109,14 @@ const int kTouchDataTypeEnd = ui::DeviceDataManagerX11::DT_TOUCH_RAW_TIMESTAMP;
namespace ui {
+namespace {
+
+bool KeyboardDeviceHasId(const ui::KeyboardDevice keyboard, unsigned int id) {
+ return keyboard.id == id;
+}
+
+} // namespace
+
bool DeviceDataManagerX11::IsCMTDataType(const int type) {
return (type >= kCMTDataTypeStart) && (type <= kCMTDataTypeEnd);
}
@@ -661,7 +672,8 @@ void DeviceDataManagerX11::InitializeValuatorsForTest(int deviceid,
}
}
-bool DeviceDataManagerX11::TouchEventNeedsCalibrate(int touch_device_id) const {
+bool DeviceDataManagerX11::TouchEventNeedsCalibrate(
+ unsigned int touch_device_id) const {
#if defined(OS_CHROMEOS) && defined(USE_XI2_MT)
int64 touch_display_id = GetDisplayForTouchDevice(touch_device_id);
if (base::SysInfo::IsRunningOnChromeOS() &&
@@ -681,10 +693,31 @@ void DeviceDataManagerX11::SetDisabledKeyboardAllowedKeys(
void DeviceDataManagerX11::DisableDevice(unsigned int deviceid) {
blocked_devices_.set(deviceid, true);
+ // TODO(rsadam@): Support blocking touchscreen devices.
+ std::vector<KeyboardDevice> keyboards = keyboard_devices();
+ std::vector<KeyboardDevice>::iterator it =
+ std::find_if(keyboards.begin(),
+ keyboards.end(),
+ std::bind2nd(std::ptr_fun(&KeyboardDeviceHasId), deviceid));
+ if (it != std::end(keyboards)) {
+ blocked_keyboards_.insert(
+ std::pair<unsigned int, KeyboardDevice>(deviceid, *it));
+ keyboards.erase(it);
+ DeviceDataManager::OnKeyboardDevicesUpdated(keyboards);
+ }
}
void DeviceDataManagerX11::EnableDevice(unsigned int deviceid) {
blocked_devices_.set(deviceid, false);
+ std::map<unsigned int, KeyboardDevice>::iterator it =
+ blocked_keyboards_.find(deviceid);
+ if (it != blocked_keyboards_.end()) {
+ std::vector<KeyboardDevice> devices = keyboard_devices();
+ // Add device to current list of active devices.
+ devices.push_back((*it).second);
+ blocked_keyboards_.erase(it);
+ DeviceDataManager::OnKeyboardDevicesUpdated(devices);
+ }
}
bool DeviceDataManagerX11::IsEventBlocked(
@@ -707,4 +740,30 @@ bool DeviceDataManagerX11::IsEventBlocked(
return blocked_devices_.test(xievent->sourceid);
}
+void DeviceDataManagerX11::OnKeyboardDevicesUpdated(
+ const std::vector<KeyboardDevice>& devices) {
+ std::vector<KeyboardDevice> keyboards(devices);
+ for (std::map<unsigned int, KeyboardDevice>::iterator blocked_iter =
+ blocked_keyboards_.begin();
+ blocked_iter != blocked_keyboards_.end();) {
+ // Check if the blocked device still exists in list of devices.
+ std::vector<KeyboardDevice>::iterator it =
+ std::find_if(keyboards.begin(),
+ keyboards.end(),
+ std::bind2nd(std::ptr_fun(&KeyboardDeviceHasId),
+ (*blocked_iter).first));
+ // If the device no longer exists, unblock it, else filter it out from our
+ // active list.
+ if (it == keyboards.end()) {
+ blocked_devices_.set((*blocked_iter).first, false);
+ blocked_keyboards_.erase(blocked_iter++);
+ } else {
+ keyboards.erase(it);
+ ++blocked_iter;
+ }
+ }
+ // Notify base class of updated list.
+ DeviceDataManager::OnKeyboardDevicesUpdated(keyboards);
+}
+
} // namespace ui
« no previous file with comments | « ui/events/x/device_data_manager_x11.h ('k') | ui/events/x/device_data_manager_x11_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698