Adds special support to the device manager for keyboards devices.

ui/events/x/device_data_manager_x11.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_EVENTS_X_DEVICE_DATA_MANAGER_X11_H_
 #define UI_EVENTS_X_DEVICE_DATA_MANAGER_X11_H_
 
 // Generically-named #defines from Xlib is conflicting with symbols in GTest.
 // So many tests .cc file #undef Bool before including device_data_manager.h,
 // which makes Bool unrecognized in XInput2.h.
 #ifndef Bool
 #define Bool int
 #endif
 
 #include <X11/extensions/XInput2.h>
 
 #include <bitset>
+#include <functional>
 #include <map>
 #include <set>
 #include <vector>
 
 #include "base/basictypes.h"
 #include "base/event_types.h"
 #include "base/memory/scoped_ptr.h"
 #include "ui/events/device_data_manager.h"
 #include "ui/events/event_constants.h"
 #include "ui/events/events_base_export.h"
@@ skipping 16 matching lines @@
 class EVENTS_BASE_EXPORT DeviceDataManagerX11 : public DeviceDataManager {
  public:
   // Enumerate additional data that one might be interested on an input event,
   // which are usually wrapped in X valuators. If you modify any of this,
   // make sure to update the kCachedAtoms data structure in the source file
   // and the k*Type[Start/End] constants used by IsCMTDataType and
   // IsTouchDataType.
   enum DataType {
     // Define the valuators used the CrOS CMT driver. Used by mice and CrOS
     // touchpads.
-    DT_CMT_SCROLL_X = 0,  // Scroll amount on the X (horizontal) direction.
-    DT_CMT_SCROLL_Y,      // Scroll amount on the Y (vertical) direction.
-    DT_CMT_ORDINAL_X,     // Original (unaccelerated) value on the X direction.
-                          // Can be used both for scrolls and flings.
-    DT_CMT_ORDINAL_Y,     // Original (unaccelerated) value on the Y direction.
-                          // Can be used both for scrolls and flings.
-    DT_CMT_START_TIME,    // Gesture start time.
-    DT_CMT_END_TIME,      // Gesture end time.
-    DT_CMT_FLING_X,       // Fling amount on the X (horizontal) direction.
-    DT_CMT_FLING_Y,       // Fling amount on the Y (vertical) direction.
-    DT_CMT_FLING_STATE,   // The state of fling gesture (whether the user just
-                          // start flinging or that he/she taps down).
-    DT_CMT_METRICS_TYPE,  // Metrics type of the metrics gesture, which are
-                          // used to wrap interesting patterns that we would
-                          // like to track via the UMA system.
-    DT_CMT_METRICS_DATA1, // Complementary data 1 of the metrics gesture.
-    DT_CMT_METRICS_DATA2, // Complementary data 2 of the metrics gesture.
-    DT_CMT_FINGER_COUNT,  // Finger counts in the current gesture. A same type
-                          // of gesture can have very different meanings based
-                          // on that (e.g. 2f scroll v.s. 3f swipe).
+    DT_CMT_SCROLL_X = 0,   // Scroll amount on the X (horizontal) direction.
+    DT_CMT_SCROLL_Y,       // Scroll amount on the Y (vertical) direction.
+    DT_CMT_ORDINAL_X,      // Original (unaccelerated) value on the X direction.
+                           // Can be used both for scrolls and flings.
+    DT_CMT_ORDINAL_Y,      // Original (unaccelerated) value on the Y direction.
+                           // Can be used both for scrolls and flings.
+    DT_CMT_START_TIME,     // Gesture start time.
+    DT_CMT_END_TIME,       // Gesture end time.
+    DT_CMT_FLING_X,        // Fling amount on the X (horizontal) direction.
+    DT_CMT_FLING_Y,        // Fling amount on the Y (vertical) direction.
+    DT_CMT_FLING_STATE,    // The state of fling gesture (whether the user just
+                           // start flinging or that he/she taps down).
+    DT_CMT_METRICS_TYPE,   // Metrics type of the metrics gesture, which are
+                           // used to wrap interesting patterns that we would
+                           // like to track via the UMA system.
+    DT_CMT_METRICS_DATA1,  // Complementary data 1 of the metrics gesture.
+    DT_CMT_METRICS_DATA2,  // Complementary data 2 of the metrics gesture.
+    DT_CMT_FINGER_COUNT,   // Finger counts in the current gesture. A same type
+                           // of gesture can have very different meanings based
+                           // on that (e.g. 2f scroll v.s. 3f swipe).
 
     // End of CMT data types.
     // Beginning of touch data types.
 
     // Define the valuators following the Multi-touch Protocol. Used by
     // touchscreen devices.
-    DT_TOUCH_MAJOR,       // Length of the touch area.
-    DT_TOUCH_MINOR,       // Width of the touch area.
-    DT_TOUCH_ORIENTATION, // Angle between the X-axis and the major axis of the
-                          // touch area.
-    DT_TOUCH_PRESSURE,    // Pressure of the touch contact.
+    DT_TOUCH_MAJOR,        // Length of the touch area.
+    DT_TOUCH_MINOR,        // Width of the touch area.
+    DT_TOUCH_ORIENTATION,  // Angle between the X-axis and the major axis of the
+                           // touch area.
+    DT_TOUCH_PRESSURE,     // Pressure of the touch contact.
 
-    DT_TOUCH_POSITION_X,  // Touch X position.
-    DT_TOUCH_POSITION_Y,  // Touch Y position.
+    DT_TOUCH_POSITION_X,   // Touch X position.
+    DT_TOUCH_POSITION_Y,   // Touch Y position.
 
     // NOTE for XInput MT: 'Tracking ID' is provided in every touch event to
     // track individual touch. 'Tracking ID' is an unsigned 32-bit value and
     // is increased for each new touch. It will wrap back to 0 when reaching
     // the numerical limit.
-    DT_TOUCH_TRACKING_ID, // ID of the touch point.
+    DT_TOUCH_TRACKING_ID,   // ID of the touch point.
 
     // Kernel timestamp from touch screen (if available).
     DT_TOUCH_RAW_TIMESTAMP,
 
     // End of touch data types.
 
-    DT_LAST_ENTRY         // This must come last.
+    DT_LAST_ENTRY           // This must come last.
   };
 
   // Data struct to store extracted data from an input event.
   typedef std::map<int, double> EventData;
 
   static void CreateInstance();
 
   // We use int because enums can be casted to ints but not vice versa.
   static bool IsCMTDataType(const int type);
   static bool IsTouchDataType(const int type);
@@ skipping 120 matching lines @@
   void SetDisabledKeyboardAllowedKeys(
       scoped_ptr<std::set<KeyboardCode> > excepted_keys);
 
   // Disables and enables events from devices by device id.
   void DisableDevice(unsigned int deviceid);
   void EnableDevice(unsigned int deviceid);
 
   // Returns true if |native_event| should be blocked.
   bool IsEventBlocked(const base::NativeEvent& native_event);
 
+ protected:
+  // DeviceHotplugEventObserver:
+  virtual void OnKeyboardDevicesUpdated(
+      const std::vector<KeyboardDevice>& devices) override;
+
  private:
   DeviceDataManagerX11();
   virtual ~DeviceDataManagerX11();
 
   // Initialize the XInput related system information.
   bool InitializeXInputInternal();
 
   // Check if an XI event contains data of the specified type.
   bool HasEventData(const XIDeviceEvent* xiev, const DataType type) const;
 
@@ skipping 42 matching lines @@
 
   // Table to keep track of the last seen value for the specified valuator for
   // a specified slot of a device. Defaults to 0 if the valuator for that slot
   // was not specified in an earlier event. With MT-B/XI2.2, valuators in an
   // XEvent are not reported if the values haven't changed from the previous
   // event. So it is necessary to remember these valuators so that chrome
   // doesn't think X/device doesn't know about the valuators. We currently
   // use this only on touchscreen devices.
   std::vector<double> last_seen_valuator_[kMaxDeviceNum][kMaxSlotNum];
 
+  // Map that stores meta-data for blocked keyboards. This is needed to restore
+  // devices when they are re-enabled.
+  std::map<unsigned int, ui::KeyboardDevice, std::less<int>> blocked_keyboards_;

[flackr, 2014/10/08 21:58:11]

You need to specify the comparator for types where operator< is defined.
Also, you should store this as <int, KeyboardDevice> to match the int deviceid
in InputDevice

[rsadam, 2014/10/09 05:19:03]

Done.

+
   // X11 atoms cache.
   X11AtomCache atom_cache_;
 
   unsigned char button_map_[256];
   int button_map_count_;
 
   DISALLOW_COPY_AND_ASSIGN(DeviceDataManagerX11);
 };
 
 }  // namespace ui
 
 #endif  // UI_EVENTS_X_DEVICE_DATA_MANAGER_X11_H_