Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 618273002: IA2 role, xml-roles are not correct for {address, aside, nav, main} (Closed)

Created:
6 years, 2 months ago by shreeramk
Modified:
6 years, 2 months ago
Reviewers:
dmazzoni, aboxhall
CC:
chromium-reviews, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, jam, yuzo+watch_chromium.org, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

IA2 role, xml-roles are not correct for {address, aside, nav, main} HTML Tags address, aside, nav, main Aria roles contentinfo, complementary, navigation Below changes are in accordance with Latest editor's draft: <address> should have IA2 role as IA2_ROLE_PARAGRAPH, IA role as ROLE_SYSTEM_TEXT and it shouldn't have any xml-role. <aside> should have IA2 role as IA2_ROLE_NOTE, IA role as ROLE_SYSTEM_GROUPING and xml-role as complementary. <main> should have IA2 role as IA2_ROLE_PARAGRAPH, IA role as ROLE_SYSTEM_GROUPING and xml-role as main. <nav> should have IA2 role as IA2_ROLE_SECTION, IA role as ROLE_SYSTEM_GROUPING with xml-role as navigation. BUG=169567, 169568, 281895, 417654 Committed: https://crrev.com/2a55b6034fbcc87d990d003bf2f055c8f191fb1e Cr-Commit-Position: refs/heads/master@{#298254}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Updating expectations #

Patch Set 4 : updating expectation for android #

Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -37 lines) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 2 4 chunks +16 lines, -6 lines 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 2 4 chunks +22 lines, -0 lines 0 comments Download
M content/renderer/accessibility/blink_ax_tree_source.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/test/data/accessibility/address.html View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/data/accessibility/address-expected-win.txt View 1 chunk +2 lines, -4 lines 0 comments Download
A + content/test/data/accessibility/aria-complementary.html View 1 chunk +2 lines, -7 lines 0 comments Download
A content/test/data/accessibility/aria-complementary-expected-android.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-complementary-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-complementary-expected-win.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-contentinfo.html View 1 chunk +2 lines, -7 lines 0 comments Download
A content/test/data/accessibility/aria-contentinfo-expected-android.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-contentinfo-expected-mac.txt View 1 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-contentinfo-expected-win.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-navigation.html View 1 chunk +13 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/aria-navigation-expected-android.txt View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A content/test/data/accessibility/aria-navigation-expected-mac.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aria-navigation-expected-win.txt View 1 chunk +2 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aside.html View 1 chunk +18 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aside-expected-android.txt View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aside-expected-mac.txt View 1 1 chunk +8 lines, -0 lines 0 comments Download
A content/test/data/accessibility/aside-expected-win.txt View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M content/test/data/accessibility/landmark-expected-win.txt View 1 2 1 chunk +8 lines, -8 lines 0 comments Download
M content/test/data/accessibility/main-expected-win.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A content/test/data/accessibility/navigation.html View 1 chunk +15 lines, -0 lines 0 comments Download
A + content/test/data/accessibility/navigation-expected-android.txt View 1 1 chunk +1 line, -1 line 0 comments Download
A content/test/data/accessibility/navigation-expected-mac.txt View 1 1 chunk +4 lines, -0 lines 0 comments Download
A content/test/data/accessibility/navigation-expected-win.txt View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
shreeramk
Please review! Thanks.
6 years, 2 months ago (2014-10-06 07:21:41 UTC) #2
dmazzoni
lgtm
6 years, 2 months ago (2014-10-06 15:34:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618273002/60001
6 years, 2 months ago (2014-10-06 15:35:44 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001) as c5ada7720f83ce42f61d6866ede167d98971c730
6 years, 2 months ago (2014-10-06 17:12:54 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 17:13:37 UTC) #7
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2a55b6034fbcc87d990d003bf2f055c8f191fb1e
Cr-Commit-Position: refs/heads/master@{#298254}

Powered by Google App Engine
This is Rietveld 408576698