Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 618253002: Revert of Streamline frame detach (Closed)

Created:
6 years, 2 months ago by eustas
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, gavinp+loader_chromium.org, oilpan-reviews, rwlbuis
Project:
blink
Visibility:
Public.

Description

Revert of Streamline frame detach (patchset #8 id:140001 of https://codereview.chromium.org/551973005/) Reason for revert: This patch breaks SitePerProcessBrowserTest.NavigateRemoteFrame on swarming bots: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/21481 Original issue's description: > Streamline frame detach > > Share a bit more code between LocalFrame and RemoteFrame, including moving the detach-time client notification down to FrameClient. > > Move the max frame counter to FrameHost instead of Page. > > Move detach logic from FrameLoader to LocalFrame, unless it manipulates FrameLoader members. > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182999 TBR=dcheng@chromium.org,abarth@chromium.org,japhet@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183040

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -83 lines) Patch
M Source/core/dom/NodeRareData.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/Frame.h View 2 chunks +7 lines, -1 line 0 comments Download
M Source/core/frame/Frame.cpp View 3 chunks +3 lines, -20 lines 0 comments Download
M Source/core/frame/FrameClient.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/frame/FrameHost.h View 2 chunks +0 lines, -10 lines 0 comments Download
M Source/core/frame/FrameHost.cpp View 2 chunks +0 lines, -22 lines 0 comments Download
M Source/core/frame/LocalFrame.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 4 chunks +15 lines, -11 lines 0 comments Download
M Source/core/frame/RemoteFrame.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 1 chunk +41 lines, -2 lines 0 comments Download
M Source/core/loader/FrameLoaderClient.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/page/Page.h View 4 chunks +17 lines, -0 lines 0 comments Download
M Source/core/page/Page.cpp View 2 chunks +14 lines, -0 lines 0 comments Download
M Source/web/FrameLoaderClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/FrameLoaderClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/RemoteFrameClientImpl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/RemoteFrameClientImpl.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
eustas
Created Revert of Streamline frame detach
6 years, 2 months ago (2014-10-01 08:28:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618253002/1
6 years, 2 months ago (2014-10-01 08:29:40 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 08:30:20 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183040

Powered by Google App Engine
This is Rietveld 408576698