Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 61823008: Introduce separate client and init path for single-threaded cc (Closed)

Created:
7 years, 1 month ago by jamesr
Modified:
7 years, 1 month ago
Reviewers:
piman, enne (OOO)
CC:
chromium-reviews, jbauman+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, Ian Vollick, jam, penghuang+watch_chromium.org, apatrick_chromium, sievers+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, cc-bugs_chromium.org, James Su, danakj+watch_chromium.org, miu+watch_chromium.org, danakj, enne (OOO), no sievers
Visibility:
Public.

Description

Introduce separate client and init path for single-threaded cc The chromium compositor can be used in either a single-threaded fashion or multi-threaded. The requirements, APIs and responsibilities of the embedder are different for these two modes. Some users of cc only use one path or the other. This adds a separate client interface and initialization path for code that only uses the single threaded path. Having a dedicated client for the single threaded path will make it possible to get rid of the WebGraphicsContext3DSwapBuffersClient which will then make it easier to break cc's dependency on WGC3D. R=piman BUG=181120 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233483

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -193 lines) Patch
M cc/layers/layer_unittest.cc View 2 chunks +10 lines, -5 lines 0 comments Download
M cc/layers/nine_patch_layer_unittest.cc View 3 chunks +3 lines, -14 lines 0 comments Download
M cc/layers/scrollbar_layer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/texture_layer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/tiled_layer_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/layers/ui_resource_layer_unittest.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M cc/test/fake_layer_tree_host.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/test/fake_layer_tree_host_client.h View 3 chunks +9 lines, -5 lines 0 comments Download
M cc/test/layer_tree_test.cc View 4 chunks +60 lines, -50 lines 0 comments Download
M cc/trees/layer_tree_host.h View 4 chunks +13 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host.cc View 4 chunks +28 lines, -16 lines 0 comments Download
M cc/trees/layer_tree_host_client.h View 1 chunk +0 lines, -3 lines 0 comments Download
A cc/trees/layer_tree_host_single_thread_client.h View 1 chunk +29 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_context.cc View 1 chunk +10 lines, -11 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/single_thread_proxy.h View 3 chunks +7 lines, -2 lines 0 comments Download
M cc/trees/single_thread_proxy.cc View 5 chunks +13 lines, -7 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.h View 4 chunks +7 lines, -2 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 3 chunks +1 line, -12 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.h View 3 chunks +9 lines, -3 lines 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 3 chunks +14 lines, -9 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 3 chunks +10 lines, -3 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M ui/compositor/compositor.h View 3 chunks +7 lines, -1 line 0 comments Download
M ui/compositor/compositor.cc View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jamesr
piman@ - review plz :) enne/danakj/etc - this changes the LayerTreeHost initialization to be more ...
7 years, 1 month ago (2013-11-06 23:49:36 UTC) #1
piman
LGTM, this is cool.
7 years, 1 month ago (2013-11-07 00:15:11 UTC) #2
piman
On 2013/11/07 00:15:11, piman wrote: > LGTM, this is cool. (BTW you missed a digit ...
7 years, 1 month ago (2013-11-07 00:16:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/61823008/1
7 years, 1 month ago (2013-11-07 00:32:39 UTC) #4
enne (OOO)
lgtm2, this is really nice cleanup.
7 years, 1 month ago (2013-11-07 00:39:00 UTC) #5
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 05:01:34 UTC) #6
Message was sent while issue was closed.
Change committed as 233483

Powered by Google App Engine
This is Rietveld 408576698