Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 61823004: Move chrome/common/extensions/incognito_handler.h to src/extensions (Closed)

Created:
7 years, 1 month ago by James Cook
Modified:
7 years, 1 month ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Move chrome/common/extensions/incognito_handler.h to src/extensions Part of moving ExtensionProcessManager to src/extensions BUG=313481 TEST=compiles R=yoz@chromium.org TBR=finnur@chromium.org for chrome/browser/ui/webui/extensions Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233391

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -139 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/messaging/message_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/preference/preference_helpers.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_info_map.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_process_manager.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_protocols.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_common.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_handlers.cc View 2 chunks +1 line, -1 line 0 comments Download
D chrome/common/extensions/incognito_handler.h View 1 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/common/extensions/incognito_handler.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + extensions/common/manifest_handlers/incognito_info.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + extensions/common/manifest_handlers/incognito_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
James Cook
yoz, PTAL This is strictly a mechanical move. I'll rebase it to pick up the ...
7 years, 1 month ago (2013-11-06 17:21:53 UTC) #1
Yoyo Zhou
LGTM
7 years, 1 month ago (2013-11-06 18:28:47 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/61823004/50001
7 years, 1 month ago (2013-11-06 19:56:28 UTC) #3
James Cook
7 years, 1 month ago (2013-11-06 22:02:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r233391 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698