MIPS: Improve runtime detection and compatibility wrt arch. revisions.

src/base/cpu.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/base/cpu.h"
 
 #if V8_LIBC_MSVCRT
 #include <intrin.h>  // __cpuid()
 #endif
 #if V8_OS_POSIX
@@ skipping 101 matching lines @@
   }
   return result;
 }
 
 #endif  // V8_HOST_ARCH_ARM
 
 #if V8_HOST_ARCH_MIPS
 int __detect_fp64_mode(void) {
   double result = 0;
   // Bit representation of (double)1 is 0x3FF0000000000000.
-  asm(
-    "lui $t0, 0x3FF0\n\t"
-    "ldc1 $f0, %0\n\t"
-    "mtc1 $t0, $f1\n\t"
-    "sdc1 $f0, %0\n\t"
-    : "+m" (result)
-    : : "t0", "$f0", "$f1", "memory");
+  __asm__ volatile(
+      ".set push\n\t"
+      ".set noreorder\n\t"
+      ".set oddspreg\n\t"
+      "lui $t0, 0x3FF0\n\t"
+      "ldc1 $f0, %0\n\t"
+      "mtc1 $t0, $f1\n\t"
+      "sdc1 $f0, %0\n\t"
+      ".set pop\n\t"
+      : "+m"(result)
+      :
+      : "t0", "$f0", "$f1", "memory");
 
   return !(result == 1);
 }
 
 
 int __detect_mips_arch_revision(void) {
   // TODO(dusmil): Do the specific syscall as soon as it is implemented in mips
-  // kernel. Currently fail-back to the least common denominator which is
-  // mips32 revision 1.
-  return 1;
+  // kernel.
+  // Detect r6 architectures through QNaN representation.
+  // The r6 variant uses IEEE2008 QNaN representation which is 7ff8xxxxxxxxxxxx,
+  // the same encoding for QNaN on x86, ARM.
+  // Non r6 variants uses 7ff7fxxxxxxxxxxx for QNaN which is SNaN on x86, ARM.
+  double result = 0;
+  uint64_t check, mask = 0x8000000000000LLU;
+  union {
+    double d;
+    uint64_t ull;
+  } conv;
+
+  __asm__ volatile(
+      ".set push\n\t"
+      ".set noreorder\n\t"
+      "ldc1 $f0, %0\n\t"
+      "div.d $f0, $f0, $f0\n\t"
+      "sdc1 $f0, %0\n\t"
+      ".set pop\n\t"
+      : "+m"(result)
+      :
+      : "$f0", "memory");
+  conv.d = result;
+  // Check bit 50 of NaN value.
+  // Fail-back to the least common denominator which is mips32 revision 1.

[paul.l..., 2014/10/02 16:26:47]

nit: this should probably be "fall-back"

[dusmil.imgtec, 2014/10/02 17:02:09]

Done.

+  check = conv.ull & mask;
+  return check ? 6 : 1;
 }
 #endif
 
 // Extract the information exposed by the kernel via /proc/cpuinfo.
 class CPUInfo FINAL {
  public:
   CPUInfo() : datalen_(0) {
     // Get the size of the cpuinfo file by reading it until the end. This is
     // required because files under /proc do not always return a valid size
     // when using fseek(0, SEEK_END) + ftell(). Nor can the be mmap()-ed.
@@ skipping 370 matching lines @@
     if (end == part) {
       part_ = 0;
     }
     delete[] part;
   }
 
 #endif
 }
 
 } }  // namespace v8::base