Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Issue 618193005: MIPS: Improve runtime detection and compatibility wrt arch. revisions. (Closed)

Created:
6 years, 2 months ago by dusmil.imgtec
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Improve runtime detection and compatibility wrt arch. revisions. TEST= BUG= R=jkummerow@chromium.org, paul.lind@imgtec.com Committed: https://code.google.com/p/v8/source/detail?r=24486

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comment in code fixed. #

Patch Set 3 : Improve revision detection not to rely on NaN representation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -20 lines) Patch
M build/toolchain.gypi View 4 chunks +15 lines, -9 lines 0 comments Download
M src/base/cpu.cc View 1 2 2 chunks +28 lines, -10 lines 0 comments Download
M src/mips/constants-mips.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
dusmil.imgtec
PTAL.
6 years, 2 months ago (2014-10-02 15:57:17 UTC) #2
paul.l...
LGTM, but this one needs v8 team review as well. https://codereview.chromium.org/618193005/diff/1/src/base/cpu.cc File src/base/cpu.cc (right): https://codereview.chromium.org/618193005/diff/1/src/base/cpu.cc#newcode165 ...
6 years, 2 months ago (2014-10-02 16:26:47 UTC) #3
dusmil.imgtec
https://codereview.chromium.org/618193005/diff/1/src/base/cpu.cc File src/base/cpu.cc (right): https://codereview.chromium.org/618193005/diff/1/src/base/cpu.cc#newcode165 src/base/cpu.cc:165: // Fail-back to the least common denominator which is ...
6 years, 2 months ago (2014-10-02 17:02:09 UTC) #4
paul.l...
There are some corner cases not covered here. Lets *not* commit this revision. We can ...
6 years, 2 months ago (2014-10-03 01:02:35 UTC) #5
paul.l...
OK, with patchset 3, this LGTM. Can one of the v8 team members PTAL as ...
6 years, 2 months ago (2014-10-08 16:48:18 UTC) #6
Jakob Kummerow
lgtm
6 years, 2 months ago (2014-10-09 09:17:20 UTC) #7
dusmil.imgtec
6 years, 2 months ago (2014-10-09 09:39:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 24486 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698