Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 618193003: Rename page-popup helper functions. (Closed)

Created:
6 years, 2 months ago by tkent
Modified:
6 years, 2 months ago
Reviewers:
keishi
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Rename page-popup helper functions. - openPicker() -> openPickerWithMock() - openPickerWithoutMock() -> openPicker(). BUG=409503 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183175

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -127 lines) Patch
M LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-ar.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-minimum-date.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-required.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-required-ar.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-ru.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-appearance-step.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-date-types.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-datetimelocal.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-datetimelocal-with-step.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-key-operations.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-mouse-operations.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-pre-100-year.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-should-not-change-datetimelocal-time.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-touch-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-type-change-onchange.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/calendar-picker-with-step.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/date-picker-ax.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/date-picker-choose-default-value-after-set-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/date-picker-events.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/datetimelocal-change-type-on-input-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/datetimelocal-picker-choose-default-value-after-set-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/datetimelocal-picker-events.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-appearance-step.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-ax.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-choose-default-value-after-set-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-key-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-mouse-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-touch-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/month-picker-with-step.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-appearance-step.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-ax.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-choose-default-value-after-set-value.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-key-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-mouse-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/calendar-picker/week-picker-touch-operations.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/color/color-suggestion-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/color/color-suggestion-picker-one-row-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/color/color-suggestion-picker-two-row-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/page-popup/page-popup-adjust-rect.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/resources/picker-common.js View 2 chunks +3 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-key-operations.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-min-max-attribute.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-mouse-operations.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-reset-value-after-reload.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/date-suggestion-picker-step-attribute.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-key-operations.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-min-max-attribute.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-mouse-operations.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-reset-value-after-reload.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-step-attribute.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-key-operations.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-min-max-attribute.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-mouse-operations.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-reset-value-after-reload.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/month-suggestion-picker-step-attribute.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-appearance-with-scroll-bar.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-key-operations.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-min-max-attribute.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-mouse-operations.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/time-suggestion-picker-step-attribute.html View 4 chunks +4 lines, -4 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-appearance.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-key-operations.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-min-max-attribute.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-mouse-operations.html View 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-reset-value-after-reload.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/suggestion-picker/week-suggestion-picker-step-attribute.html View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tkent
Hattori-san, please review this.
6 years, 2 months ago (2014-10-02 08:58:59 UTC) #2
keishi
lgtm
6 years, 2 months ago (2014-10-03 03:04:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618193003/1
6 years, 2 months ago (2014-10-03 03:05:57 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 03:11:48 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183175

Powered by Google App Engine
This is Rietveld 408576698