All changes to ui/webui/ from bookmarks CL that block other CLs

All changes to ui/webui/ from bookmarks CL that block other CLs

Already reviewed here: https://chromiumcodereview.appspot.com/543863002/

R=dbeam@chromium.org
BUG=393873
Committed: https://crrev.com/5fa737de90b9f1ef3e359d9cf3d697cafd8e2d9f
Cr-Commit-Position: refs/heads/master@{#297536}

[Vitaly Pavlenko, 2014-09-30 21:08:25]

vitalyp@chromium.org changed reviewers:
+ dbeam@chromium.org

[Vitaly Pavlenko, 2014-09-30 21:09:01]

On 2014/09/30 21:04:23, Vitaly Pavlenko wrote:

dbeam@, please, review or lgtm these reviewed blocker files from
chrome://bookmarks

[Dan Beam, 2014-09-30 21:11:16]

lgtm

https://chromiumcodereview.appspot.com/618133002/diff/1/ui/webui/resources/js...
File ui/webui/resources/js/cr/event_target.js (right):

https://chromiumcodereview.appspot.com/618133002/diff/1/ui/webui/resources/js...
ui/webui/resources/js/cr/event_target.js:26: * @param
{EventListener|function(!Event):(boolean|undefined)} handler The
@typedef

https://chromiumcodereview.appspot.com/618133002/diff/1/ui/webui/resources/js...
File ui/webui/resources/js/cr/link_controller.js (right):

https://chromiumcodereview.appspot.com/618133002/diff/1/ui/webui/resources/js...
ui/webui/resources/js/cr/link_controller.js:44: * @param {!(LoadTimeData)}
localStrings The local strings object
remove ()

[Vitaly Pavlenko, 2014-09-30 21:17:11]

https://chromiumcodereview.appspot.com/618133002/diff/1/ui/webui/resources/js...
File ui/webui/resources/js/cr/event_target.js (right):

https://chromiumcodereview.appspot.com/618133002/diff/1/ui/webui/resources/js...
ui/webui/resources/js/cr/event_target.js:26: * @param
{EventListener|function(!Event):(boolean|undefined)} handler The
On 2014/09/30 21:11:16, Dan Beam wrote:
> @typedef

Done.

https://chromiumcodereview.appspot.com/618133002/diff/1/ui/webui/resources/js...
File ui/webui/resources/js/cr/link_controller.js (right):

https://chromiumcodereview.appspot.com/618133002/diff/1/ui/webui/resources/js...
ui/webui/resources/js/cr/link_controller.js:44: * @param {!(LoadTimeData)}
localStrings The local strings object
On 2014/09/30 21:11:16, Dan Beam wrote:
> remove ()

Done.

[Vitaly Pavlenko, 2014-09-30 21:17:13]

The CQ bit was checked by vitalyp@chromium.org

[Vitaly Pavlenko, 2014-09-30 21:17:42]

The CQ bit was unchecked by vitalyp@chromium.org

[Vitaly Pavlenko, 2014-09-30 21:19:25]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-09-30 21:21:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/618133002/40001

[commit-bot: I haz the power, 2014-09-30 23:07:33]

Committed patchset #3 (id:40001) as 47e81b05613ddbec0a34d300b6efddf7fa89bee6

[commit-bot: I haz the power, 2014-09-30 23:08:18]

Patchset 3 (id:??) landed as
https://crrev.com/5fa737de90b9f1ef3e359d9cf3d697cafd8e2d9f
Cr-Commit-Position: refs/heads/master@{#297536}

[Nico, 2014-10-01 10:22:46]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/620663004/ by thakis@chromium.org.

The reason for reverting is: Broke testDropFromOutsideSource:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg...
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.6%20Tests%20%28dbg....

[Nico, 2014-10-01 10:27:26]

On 2014/10/01 10:22:46, Nico (away until Oct 27) wrote:
> A revert of this CL (patchset #3 id:40001) has been created in
> https://codereview.chromium.org/620663004/ by mailto:thakis@chromium.org.

The revert doesn't apply cleanly; apparently 6 CLs landed after this. I don't
have a checkout on this machine, so I can't revert all 7 CLs from here. Please
take a look quickly (main waterfall bots are red), and in the future please
check that one change actually works on the main waterfall before landing
something blocked on the first CL.

[Vitaly Pavlenko, 2014-10-01 17:52:54]

On 2014/10/01 10:27:26, Nico (away until Oct 27) wrote:
> On 2014/10/01 10:22:46, Nico (away until Oct 27) wrote:
> > A revert of this CL (patchset #3 id:40001) has been created in
> > https://codereview.chromium.org/620663004/ by mailto:thakis@chromium.org.
> 
> The revert doesn't apply cleanly; apparently 6 CLs landed after this. I don't
> have a checkout on this machine, so I can't revert all 7 CLs from here. Please
> take a look quickly (main waterfall bots are red), and in the future please
> check that one change actually works on the main waterfall before landing
> something blocked on the first CL.

The tree is now green. Was this patch reverted or was there any other fix
applied?

[Dan Beam, 2014-10-01 17:57:49]

On 2014/10/01 17:52:54, Vitaly Pavlenko wrote:
> On 2014/10/01 10:27:26, Nico (away until Oct 27) wrote:
> > On 2014/10/01 10:22:46, Nico (away until Oct 27) wrote:
> > > A revert of this CL (patchset #3 id:40001) has been created in
> > > https://codereview.chromium.org/620663004/ by mailto:thakis@chromium.org.
> > 
> > The revert doesn't apply cleanly; apparently 6 CLs landed after this. I
don't
> > have a checkout on this machine, so I can't revert all 7 CLs from here.
Please
> > take a look quickly (main waterfall bots are red), and in the future please
> > check that one change actually works on the main waterfall before landing
> > something blocked on the first CL.
> 
> The tree is now green. Was this patch reverted or was there any other fix
> applied?

the test was disabled