Allow PPB_ImageData_Impl to be created in a way that is compatible with unittests

Allow PPB_ImageData_Impl to be created in a way that is compatible with unittests

On some platforms, PPB_ImageData_Impl needs to send a message to the browser to create
its transport dib. For unittests, this doesn't work and there is no sandbox so the
transport dib can be created directly. This adds a construction flag to PPB_ImageData_Impl
which allows it to be created in a way that works in unittests.

BUG=
R=bbudge@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235071

[bbudge, 2013-11-11 12:24:06]

https://codereview.chromium.org/61813003/diff/1/content/renderer/pepper/ppb_i...
File content/renderer/pepper/ppb_image_data_impl.cc (right):

https://codereview.chromium.org/61813003/diff/1/content/renderer/pepper/ppb_i...
content/renderer/pepper/ppb_image_data_impl.cc:30: bool is_browser_allocated)
Couldn't we just call IsBrowserAllocated on the type here?

[bbudge, 2013-11-11 19:09:14]

https://codereview.chromium.org/61813003/diff/1/content/renderer/pepper/ppb_i...
File content/renderer/pepper/ppb_image_data_impl.cc (right):

https://codereview.chromium.org/61813003/diff/1/content/renderer/pepper/ppb_i...
content/renderer/pepper/ppb_image_data_impl.cc:30: bool is_browser_allocated)
On 2013/11/11 12:24:06, bbudge1 wrote:
> Couldn't we just call IsBrowserAllocated on the type here?

Never mind, I realized this is the whole point of this CL.

[bbudge, 2013-11-11 19:25:57]

I like how you reduce the platform specific code and pass the backing store in
to the PepperGraphics2DHost.

Did you consider a design where a new PPB_ImageData_Shared type value would be
defined instead of changing the PPB_ImageData_Impl ctor? i.e. the ImageDataTypes
would be PLATFORM, SIMPLE, and TESTING. Then you wouldn't need the static
IsBrowserCreated method, and wouldn't have to change the PPB_ImageData_Impl ctor
and its call sites.

[raymes, 2013-11-12 02:30:59]

I wanted to avoid adding another enum option because I only really want to
change the PPB_ImageData_Impl ctor and that enum is used in a bunch of other
places as well. For now I just added a separate constructor that takes a ForTest
struct. What do you think about that?

Thanks!

[bbudge, 2013-11-12 14:40:49]

I like it. LGTM
Thanks!

[commit-bot: I haz the power, 2013-11-12 23:36:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/61813003/100001

[commit-bot: I haz the power, 2013-11-13 01:54:38]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-14 00:50:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/61813003/290002

[commit-bot: I haz the power, 2013-11-14 02:04:13]

Retried try job too often on mac for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[commit-bot: I haz the power, 2013-11-14 02:11:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/raymes@chromium.org/61813003/290002

[commit-bot: I haz the power, 2013-11-14 03:08:18]

Retried try job too often on mac for step(s) compile
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...

[raymes, 2013-11-14 06:45:57]

Committed patchset #5 manually as r235071 (presubmit successful).