Issue 618123005: Revert "Use symbols instead of hidden properties for i18n markers."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 618123005: Revert "Use symbols instead of hidden properties for i18n markers." (Closed)

Created:
6 years, 2 months ago by Yang

Modified:
6 years, 2 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Revert "Use symbols instead of hidden properties for i18n markers." This reverts r24345. TBR=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24346

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -140 lines)			Patch
M	include/v8.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/factory.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/heap-snapshot-generator.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/heap/heap.h	View	4 chunks	+91 lines, -102 lines	0 comments	Download
M	src/heap/heap.cc	View	1 chunk	+14 lines, -4 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	src/runtime/runtime.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/runtime/runtime.cc	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	src/runtime/runtime-i18n.cc	View	4 chunks	+11 lines, -12 lines	0 comments	Download
A +	test/mjsunit/test-hidden-string.js	View	1 chunk	+4 lines, -7 lines	0 comments	Download

Total messages: 2 (0 generated)

Yang

6 years, 2 months ago (2014-10-01 07:34:10 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24346 (tree was closed).