Chromium Code Reviews Chromium Code Reviews
Issue 618083003:
QUIC - track the open and close states of disk cache entries of (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index fa0f0b9357fec88badb464c824e63b5c217b5407..a9ad5725367405e05e484c6d2dcd4a66c679fb73 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -16818,6 +16818,11 @@ Therefore, the affected-histogram name has to have at least one dot in it. |
| </summary> |
| </histogram> |
| +<histogram name="Net.QuicDiskCache.EntryState" enum="QuicDiskCacheEntryState"> |
| + <owner>rtenneti@chromium.org</owner> |
| + <summary>Tracks the open and close state of the disk cache entry.</summary> |
|
Ilya Sherman
2014/10/01 19:47:36
nit: What is "the disk cache entry"? Is there jus
Ilya Sherman
2014/10/01 19:47:36
nit: Please document when this is recorded. I *th
ramant (doing other things)
2014/10/01 21:56:31
We record each time disk cache entry is either ope
ramant (doing other things)
2014/10/01 21:56:31
Done.
|
| +</histogram> |
| + |
| <histogram name="Net.QuicEphemeralPortsSuggested"> |
| <owner>rch@chromium.org</owner> |
| <summary>The number of ports suggested per server.</summary> |
| @@ -49736,6 +49741,11 @@ To add a new entry, add it with any value and run test to compute valid value. |
| <int value="7" label="Address and port match: IPv6 IPv6"/> |
| </enum> |
| +<enum name="QuicDiskCacheEntryState" type="int"> |
| + <int value="0" label="OPENED"/> |
| + <int value="1" label="CLOSED"/> |
|
Ilya Sherman
2014/10/01 19:47:36
nit: These are meant to be human-readability-orien
ramant (doing other things)
2014/10/01 21:56:31
Done.
|
| +</enum> |
| + |
| <enum name="QuicErrorCodes" type="int"> |
| <int value="0" label="NO_ERROR"/> |
| <int value="1" label="INTERNAL_ERROR"/> |
