Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issue 618043002: Remove extraneous line from CompareWrapper test (Closed)

Created:
6 years, 2 months ago by andrew_low
Modified:
6 years, 2 months ago
Reviewers:
titzer, Sven Panne
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Remove extraneous line from CompareWrapper test On platforms without TurboFan (PowerPC) the CompareWrapper test was failing. It appears the line RawMachineAssemblerTester<int32_t> m; was causing the issue, and does not appear to be required for the test to operate correctly. Removing it resolves the crash on non TurboFan platforms BUG= R=titzer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24424

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M test/cctest/compiler/codegen-tester.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
andrew_low
6 years, 2 months ago (2014-09-30 19:38:44 UTC) #2
titzer
lgtm
6 years, 2 months ago (2014-10-01 08:14:44 UTC) #3
andrew_low
On 2014/10/01 08:14:44, titzer wrote: > lgtm Thanks. I've got a bunch of success messages ...
6 years, 2 months ago (2014-10-01 13:11:15 UTC) #4
andrew_low
On 2014/10/01 13:11:15, andrew_low wrote: > On 2014/10/01 08:14:44, titzer wrote: > > lgtm > ...
6 years, 2 months ago (2014-10-01 13:18:33 UTC) #5
andrew_low
What else has to happen to get this change accepted?
6 years, 2 months ago (2014-10-02 19:28:55 UTC) #6
titzer
6 years, 2 months ago (2014-10-06 16:26:35 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as 24424 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698