Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Unified Diff: content/renderer/render_widget.cc

Issue 618013003: Support fullscreen for non-video elements in the WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactorFullscreenNonMedia
Patch Set: Added comment and android ifdefs Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 8658aebb8b92cf921e280a6fe469366142dd0fe3..a5e95433ccd5afb6235db8940bdc6066f6c4fda1 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -1710,9 +1710,19 @@ void RenderWidget::DidToggleFullscreen() {
return;
if (is_fullscreen_) {
+ // NOTE: for fullscreen video the ordering is important.
+ // 1. webwidget_->didEnterFullScreen() creates the ContentVideoView
+ // 2. which will be added to the window once
+ // ViewHostMsg_DidEnterFullscreen is received.
webwidget_->didEnterFullScreen();
+#if defined(OS_ANDROID)
+ Send(new ViewHostMsg_DidEnterFullscreen(routing_id_));
+#endif
} else {
webwidget_->didExitFullScreen();
+#if defined(OS_ANDROID)
+ Send(new ViewHostMsg_DidExitFullscreen(routing_id_));
+#endif
}
}

Powered by Google App Engine
This is Rietveld 408576698