content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java - Issue 618013003: Support fullscreen for non-video elements in the WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Issue 618013003: Support fullscreen for non-video elements in the WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactorFullscreenNonMedia

Patch Set: Fix failing test Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« android_webview/javatests/src/org/chromium/android_webview/test/AwContentsClientGetVideoLoadingProgressViewTest.java ('K') | « content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java ('k') | content/public/common/common_param_traits_macros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

index 65a6737db55bdb60af51d40d78d4765290907119..aec48cd0002a97e7e71d871a1b8d4b724c08ec51 100644

--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

@@ -392,7 +392,6 @@ public class ContentViewCore

/**

* @return The context used for creating this ContentViewCore.

- @CalledByNative

public Context getContext() {

return mContext;

}

@@ -2702,6 +2701,7 @@ public class ContentViewCore

}

/**

+ *

* @return The cached copy of render positions and scales.

public RenderCoordinates getRenderCoordinates() {

@@ -2794,8 +2794,7 @@ public class ContentViewCore

private native long nativeInit(long webContentsPtr,

long viewAndroidPtr, long windowAndroidPtr, HashSet<Object> retainedObjectSet);

- @CalledByNative

- private ContentVideoViewClient getContentVideoViewClient() {

+ ContentVideoViewClient getContentVideoViewClient() {

return getContentViewClient().getContentVideoViewClient();

}