Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1331)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContents.java

Issue 618013003: Support fullscreen for non-video elements in the WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactorFullscreenNonMedia
Patch Set: Fix failing test Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContents.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContents.java b/android_webview/java/src/org/chromium/android_webview/AwContents.java
index d8a2eeaeced48d8890354e32058ddc5c3ed7c440..a4d2d257589262704ee9371382626a51db13c5b5 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContents.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContents.java
@@ -581,8 +581,8 @@ public class AwContents {
mDIPScale = DeviceDisplayInfo.create(mContext).getDIPScale();
mLayoutSizer.setDelegate(new AwLayoutSizerDelegate());
mLayoutSizer.setDIPScale(mDIPScale);
- mWebContentsDelegate = new AwWebContentsDelegateAdapter(this, contentsClient,
- mContainerView, mContext);
+ mWebContentsDelegate = new AwWebContentsDelegateAdapter(
+ this, contentsClient, mContentViewClient, mContext, mContainerView);
mContentsClientBridge = new AwContentsClientBridge(contentsClient,
mBrowserContext.getKeyStore(), AwContentsStatics.getClientCertLookupTable());
mZoomControls = new AwZoomControls(this);
@@ -668,6 +668,13 @@ public class AwContents {
}
/**
+ * Called when the app has requested to exit fullscreen.
+ */
+ void requestExitFullscreen() {
+ mContentViewCore.getWebContents().exitFullscreen();
+ }
+
+ /**
* Returns this {@link AwContents} to embedded mode, where the {@link AwContents} are drawn
* in the WebView.
*/

Powered by Google App Engine
This is Rietveld 408576698