content/common/view_messages.h - Issue 618013003: Support fullscreen for non-video elements in the WebView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/view_messages.h

Issue 618013003: Support fullscreen for non-video elements in the WebView. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@refactorFullscreenNonMedia

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/ContentVideoView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/view_messages.h

diff --git a/content/common/view_messages.h b/content/common/view_messages.h

index 3e3e7d471714978ed8b8ca7e1f3f2abc5ef9fa96..d695a0ede9ef0d370cd56cadd1754cbd54544c7c 100644

--- a/content/common/view_messages.h

+++ b/content/common/view_messages.h

@@ -1595,6 +1595,13 @@ IPC_MESSAGE_ROUTED3(ViewHostMsg_SmartClipDataExtracted,

base::string16 /* html */,

gfx::Rect /* rect */)

+// Messages sent from the renderer to the browser after the page has been

+// bound into / out of fullscreen. In the case of video only at this point

Tom Sepez 2014/10/02 17:28:59 I don't understand the sentence "In the case of vi

Ignacio Solla 2014/10/03 09:45:20 Removed the second sentence, as it is just too ver

+// will the ContentVideoView have been created, which the browser is

+// responsible of showing.

+IPC_MESSAGE_ROUTED0(ViewHostMsg_DidEnterFullscreen)

+IPC_MESSAGE_ROUTED0(ViewHostMsg_DidExitFullscreen)

#elif defined(OS_MACOSX)

// Request that the browser load a font into shared memory for us.

IPC_SYNC_MESSAGE_CONTROL1_3(ViewHostMsg_LoadFont,