Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 618013002: Instrumented libraries: replace some makefile patches with sed invocations. (Closed)

Created:
6 years, 2 months ago by earthdok
Modified:
6 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Instrumented libraries: replace some makefile patches with sed invocations. Some cases are simple enough that a search and replace is sufficient. At the same time, the fewer patches we have, the less time will be spent rebasing them. BUG=414189 TBR=glider@chromium.org NOTRY=true Committed: https://crrev.com/72058c85190c68b203bf7ed0099f86307ee4ecaf Cr-Commit-Position: refs/heads/master@{#297474}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -30 lines) Patch
M third_party/instrumented_libraries/instrumented_libraries.gyp View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/instrumented_libraries/patches/libgdk-pixbuf2.0-0.diff View 1 chunk +0 lines, -14 lines 0 comments Download
M third_party/instrumented_libraries/patches/libgtk2.0-0.diff View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/instrumented_libraries/scripts/libgdk-pixbuf2.0-0.sh View 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/instrumented_libraries/scripts/libgtk2.0-0.sh View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
earthdok
6 years, 2 months ago (2014-09-30 19:09:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618013002/1
6 years, 2 months ago (2014-09-30 19:11:22 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as a1f774f49a25fcafa56fd57536108ab44c055557
6 years, 2 months ago (2014-09-30 19:12:44 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/72058c85190c68b203bf7ed0099f86307ee4ecaf Cr-Commit-Position: refs/heads/master@{#297474}
6 years, 2 months ago (2014-09-30 19:13:21 UTC) #5
Alexander Potapenko
6 years, 2 months ago (2014-10-03 12:54:27 UTC) #6
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698