[GCM] Handling connection events in GCMAccountTracker

google_apis/gaia/fake_oauth2_token_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "google_apis/gaia/fake_oauth2_token_service.h"
 
 FakeOAuth2TokenService::PendingRequest::PendingRequest() {
 }
 
 FakeOAuth2TokenService::PendingRequest::~PendingRequest() {
@@ skipping 48 matching lines @@
 
 void FakeOAuth2TokenService::RemoveAccount(const std::string& account_id) {
   account_ids_.erase(account_id);
   FireRefreshTokenRevoked(account_id);
 }
 
 void FakeOAuth2TokenService::IssueAllTokensForAccount(
     const std::string& account_id,
     const std::string& access_token,
     const base::Time& expiration) {
-
   // Walk the requests and notify the callbacks.
-  for (std::vector<PendingRequest>::iterator it = pending_requests_.begin();
-       it != pending_requests_.end(); ++it) {
+  std::vector<PendingRequest> pending_requests_copy = pending_requests_;
+  for (std::vector<PendingRequest>::iterator it = pending_requests_copy.begin();
+       it != pending_requests_copy.end();
+       ++it) {
     if (it->request && (account_id == it->account_id)) {
       it->request->InformConsumer(
           GoogleServiceAuthError::AuthErrorNone(), access_token, expiration);
     }
   }
 }
 
 void FakeOAuth2TokenService::IssueErrorForAllPendingRequestsForAccount(
     const std::string& account_id,
     const GoogleServiceAuthError& auth_error) {
   // Walk the requests and notify the callbacks.
-  for (std::vector<PendingRequest>::iterator it = pending_requests_.begin();
-       it != pending_requests_.end();
+  // Using a copy to make sure retyring a request does not cause a stack when

[Nicolas Zea, 2014/10/08 00:36:35]

nit:
retyring -> retrying
cause a stack -> cause a stack overflow

Also have comment int he above code too?

[fgorski, 2014/10/08 18:04:28]

Done.

+  // incrementing the iterator.
+  std::vector<PendingRequest> pending_requests_copy = pending_requests_;
+  for (std::vector<PendingRequest>::iterator it = pending_requests_copy.begin();
+       it != pending_requests_copy.end();
        ++it) {
     if (it->request && (account_id == it->account_id)) {
       it->request->InformConsumer(auth_error, std::string(), base::Time());
     }
   }
 }
 
 OAuth2AccessTokenFetcher* FakeOAuth2TokenService::CreateAccessTokenFetcher(
     const std::string& account_id,
     net::URLRequestContextGetter* getter,
     OAuth2AccessTokenConsumer* consumer) {
   // |FakeOAuth2TokenService| overrides |FetchOAuth2Token| and thus
   // |CreateAccessTokenFetcher| should never be called.
   NOTREACHED();
   return NULL;
 }