Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 617983002: Fix swarming of browser_tests and sync_integration_tests on debug windows. (Closed)

Created:
6 years, 2 months ago by jam
Modified:
6 years, 2 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix swarming of browser_tests and sync_integration_tests on debug windows. They need base.isolate to bring in the VS runtime DLLs. BUG=414808 R=maruel@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/ae092e2a50702e43fc8165eaadd84c7f64977945 Committed: https://chromium.googlesource.com/chromium/src/+/1a1faa8e07d852a65650779f5f5d019199a1b05b

Patch Set 1 #

Patch Set 2 : reupload after revert #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser_tests.isolate View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
jam
6 years, 2 months ago (2014-09-30 18:14:05 UTC) #2
M-A Ruel
lgtm
6 years, 2 months ago (2014-09-30 18:15:38 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ae092e2a50702e43fc8165eaadd84c7f64977945 Cr-Commit-Position: refs/heads/master@{#297456}
6 years, 2 months ago (2014-09-30 18:21:16 UTC) #4
jam
Committed patchset #1 (id:1) manually as ae092e2a50702e43fc8165eaadd84c7f64977945 (presubmit successful).
6 years, 2 months ago (2014-09-30 18:21:18 UTC) #5
msw
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/620603002/ by msw@chromium.org. ...
6 years, 2 months ago (2014-09-30 18:40:18 UTC) #6
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/1a1faa8e07d852a65650779f5f5d019199a1b05b Cr-Commit-Position: refs/heads/master@{#297473}
6 years, 2 months ago (2014-09-30 19:12:48 UTC) #7
jam
6 years, 2 months ago (2014-09-30 19:12:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1a1faa8e07d852a65650779f5f5d019199a1b05b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698