Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(778)

Issue 617973002: Remove assert() from getChildElement() to fix the bug caused by https://chromiumcodereview.appspot.… (Closed)

Created:
6 years, 2 months ago by Vitaly Pavlenko
Modified:
6 years, 2 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@true_master
Project:
chromium
Visibility:
Public.

Description

Remove assert() from getChildElement() to fix the bug caused by https://chromiumcodereview.appspot.com/575333002/ BUG=418532 R=vitalybuka@chromium.org Committed: https://crrev.com/587da175d3a69c3792cd64b579924c3273b448a1 Cr-Commit-Position: refs/heads/master@{#297484}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/resources/print_preview/component.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Vitaly Pavlenko
6 years, 2 months ago (2014-09-30 17:52:00 UTC) #1
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 2 months ago (2014-09-30 18:40:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617973002/1
6 years, 2 months ago (2014-09-30 18:43:06 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as ca26172300a3842a123a0d88dad072d2e8d4dac3
6 years, 2 months ago (2014-09-30 19:45:05 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 19:46:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/587da175d3a69c3792cd64b579924c3273b448a1
Cr-Commit-Position: refs/heads/master@{#297484}

Powered by Google App Engine
This is Rietveld 408576698