Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(774)

Issue 617963005: [Linux] Add a People menu item to the global menu bar. (Closed)

Created:
6 years, 2 months ago by noms (inactive)
Modified:
6 years, 2 months ago
Reviewers:
Elliot Glaysher, sky, erg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Linux] Add a People menu item to the global menu bar. This menu should look like the Mac one, and have a list of profiles, with a checkmark for the active profile, and Edit/Add Person buttons. Screenshots: https://drive.google.com/open?id=0B1B1Up4p2NRMVmhCMXFpQUFSVDQ&authuser=1 BUG=404662 Committed: https://crrev.com/ba026c17fc73a953a549e64a2a50c601072234a7 Cr-Commit-Position: refs/heads/master@{#297864}

Patch Set 1 #

Total comments: 6

Patch Set 2 : erg review #

Patch Set 3 : fix unit tests #

Patch Set 4 : +elliot as an owner #

Patch Set 5 : + dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -1 line) Patch
M chrome/browser/ui/views/frame/OWNERS View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.h View 7 chunks +23 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/global_menu_bar_x11.cc View 1 2 3 4 11 chunks +109 lines, -0 lines 0 comments Download

Messages

Total messages: 24 (5 generated)
noms (inactive)
Hi Scott, This CL is adding a "People" menu item to the Linux global menu. ...
6 years, 2 months ago (2014-10-01 19:00:17 UTC) #2
sky
I'm punting this to erg
6 years, 2 months ago (2014-10-01 20:06:30 UTC) #4
Elliot Glaysher
https://codereview.chromium.org/617963005/diff/1/chrome/browser/ui/views/frame/global_menu_bar_x11.cc File chrome/browser/ui/views/frame/global_menu_bar_x11.cc (right): https://codereview.chromium.org/617963005/diff/1/chrome/browser/ui/views/frame/global_menu_bar_x11.cc#newcode652 chrome/browser/ui/views/frame/global_menu_bar_x11.cc:652: // should be disabled. OK, so I have two ...
6 years, 2 months ago (2014-10-01 20:27:53 UTC) #6
noms (inactive)
https://codereview.chromium.org/617963005/diff/1/chrome/browser/ui/views/frame/global_menu_bar_x11.cc File chrome/browser/ui/views/frame/global_menu_bar_x11.cc (right): https://codereview.chromium.org/617963005/diff/1/chrome/browser/ui/views/frame/global_menu_bar_x11.cc#newcode652 chrome/browser/ui/views/frame/global_menu_bar_x11.cc:652: // should be disabled. Yup, that's it. The checkmark ...
6 years, 2 months ago (2014-10-01 20:34:14 UTC) #7
Elliot Glaysher
lgtm
6 years, 2 months ago (2014-10-01 20:35:52 UTC) #8
noms (inactive)
Thanks Elliot! Scott: adding you back for an owners stamp.
6 years, 2 months ago (2014-10-01 20:37:23 UTC) #10
noms (inactive)
Elliot: I made a small change and moved the instantiation of the avatar menu to ...
6 years, 2 months ago (2014-10-01 20:54:12 UTC) #11
Elliot Glaysher
On 2014/10/01 20:54:12, Monica Dinculescu wrote: > Elliot: I made a small change and moved ...
6 years, 2 months ago (2014-10-01 21:08:48 UTC) #12
noms (inactive)
Hmmm is that even possible? InitServer should be called as soon as you have a ...
6 years, 2 months ago (2014-10-01 21:12:19 UTC) #13
Elliot Glaysher
On 2014/10/01 21:12:19, Monica Dinculescu wrote: > Hmmm is that even possible? InitServer should be ...
6 years, 2 months ago (2014-10-01 21:17:44 UTC) #14
sky
Can you update OWNERS with erg as owner for *x11 in this directory?
6 years, 2 months ago (2014-10-01 23:28:37 UTC) #15
noms (inactive)
Done! Added Elliot as an owner. On 2014/10/01 23:28:37, sky wrote: > Can you update ...
6 years, 2 months ago (2014-10-02 15:09:16 UTC) #16
noms (inactive)
On 2014/10/01 21:17:44, Elliot Glaysher wrote: > On 2014/10/01 21:12:19, Monica Dinculescu wrote: > > ...
6 years, 2 months ago (2014-10-02 15:31:23 UTC) #17
sky
LGTM
6 years, 2 months ago (2014-10-02 15:35:58 UTC) #18
Elliot Glaysher
lgtm++ I think just putting a DCHECK for that condition for documentation purposes would be ...
6 years, 2 months ago (2014-10-02 17:30:58 UTC) #19
noms (inactive)
On 2014/10/02 17:30:58, Elliot Glaysher wrote: > lgtm++ > > I think just putting a ...
6 years, 2 months ago (2014-10-02 17:41:09 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617963005/80001
6 years, 2 months ago (2014-10-02 17:42:00 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001) as c65c362c3c87f62faac8199727babf9f747e2c28
6 years, 2 months ago (2014-10-02 18:09:54 UTC) #23
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 18:10:31 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/ba026c17fc73a953a549e64a2a50c601072234a7
Cr-Commit-Position: refs/heads/master@{#297864}

Powered by Google App Engine
This is Rietveld 408576698