Iterative graph traversal in FlowGraph::DiscoverBlocks()

runtime/vm/intermediate_language.h

Index: runtime/vm/intermediate_language.h
diff --git a/runtime/vm/intermediate_language.h b/runtime/vm/intermediate_language.h
index 3b0746e70c5910ce02b0ec411cf95775d6c8d54c..27a75a24c19e5333072d2ddf423d48f6b6f9cbb7 100644
--- a/runtime/vm/intermediate_language.h
+++ b/runtime/vm/intermediate_language.h
@@ -1145,26 +1145,20 @@ class BlockEntryInstr : public Instruction {
     return parallel_move_;
   }
 
-  // Discover basic-block structure by performing a recursive depth first
-  // traversal of the instruction graph reachable from this instruction.  As
-  // a side effect, the block entry instructions in the graph are assigned
-  // numbers in both preorder and postorder.  The array 'preorder' maps
-  // preorder block numbers to the block entry instruction with that number
-  // and analogously for the array 'postorder'.  The depth first spanning
-  // tree is recorded in the array 'parent', which maps preorder block
-  // numbers to the preorder number of the block's spanning-tree parent.
-  // The array 'assigned_vars' maps preorder block numbers to the set of
-  // assigned frame-allocated local variables in the block.  As a side
-  // effect of this function, the set of basic block predecessors (e.g.,
-  // block entry instructions of predecessor blocks) and also the last
-  // instruction in the block is recorded in each entry instruction.
-  void DiscoverBlocks(
+  // Discover basic-block structure of the current block.  Must be called
+  // on all graph blocks in preorder to yield valid results.  As a side effect,
+  // the block entry instructions in the graph are assigned preorder numbers.
+  // The array 'preorder' maps preorder block numbers to the block entry
+  // instruction with that number.  The depth first spanning tree is recorded
+  // in the array 'parent', which maps preorder block numbers to the preorder
+  // number of the block's spanning-tree parent.  As a side effect of this
+  // function, the set of basic block predecessors (e.g., block entry
+  // instructions of predecessor blocks) and also the last instruction in the
+  // block is recorded in each entry instruction.
+  bool DiscoverBlock(

[Vyacheslav Egorov (Google), 2014/10/09 14:22:19]

Please document return value (when it returns true and when it returns false)

       BlockEntryInstr* predecessor,
       GrowableArray<BlockEntryInstr*>* preorder,
-      GrowableArray<BlockEntryInstr*>* postorder,
-      GrowableArray<intptr_t>* parent,
-      intptr_t variable_count,
-      intptr_t fixed_parameter_count);
+      GrowableArray<intptr_t>* parent);
 
   // Perform a depth first search to prune code not reachable from an OSR
   // entry point.