Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 617933002: Remove the usbPrivate API. (Closed)

Created:
6 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove the usbPrivate API. This API was to be used by WebUI that enumerates USB devices. This is being reimplemented as native UI so the API is no longer necessary. BUG= Committed: https://crrev.com/9fd4726662eacd649b3071410d5d4c1d5f58c84d Cr-Commit-Position: refs/heads/master@{#297548}

Patch Set 1 : #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased again. This patch is fighting for an edit in _api_features.json. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -238 lines) Patch
M extensions/browser/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D extensions/browser/api/usb_private/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/browser/api/usb_private/usb_private_api.h View 1 chunk +0 lines, -49 lines 0 comments Download
D extensions/browser/api/usb_private/usb_private_api.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M extensions/common/api/_api_features.json View 2 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/common/api/schemas.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D extensions/common/api/usb_private.idl View 1 chunk +0 lines, -39 lines 0 comments Download
M extensions/extensions.gyp View 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Reilly Grant (use Gerrit)
6 years, 2 months ago (2014-09-30 18:01:18 UTC) #4
Ken Rockot(use gerrit already)
lgtm
6 years, 2 months ago (2014-09-30 18:03:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617933002/40001
6 years, 2 months ago (2014-09-30 22:01:59 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/57956)
6 years, 2 months ago (2014-09-30 22:15:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617933002/80001
6 years, 2 months ago (2014-09-30 23:27:44 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:80001) as b4e64871309d9eb47542b39879be9eec4aa2edb0
6 years, 2 months ago (2014-09-30 23:48:31 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 23:49:05 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9fd4726662eacd649b3071410d5d4c1d5f58c84d
Cr-Commit-Position: refs/heads/master@{#297548}

Powered by Google App Engine
This is Rietveld 408576698