Remove my debug output from browser_tests (added in https://chromiumcodereview.appspot.com/54386300…

Remove my debug output from browser_tests (added in https://chromiumcodereview.appspot.com/543863002/)

R=dbeam@chromium.org
BUG=393873
Committed: https://crrev.com/54f860ff71db682e634fe6fd813b1e6710d13a91
Cr-Commit-Position: refs/heads/master@{#297590}

[Dan Beam, 2014-10-01 01:27:08]

lgtm

[Vitaly Pavlenko, 2014-10-01 02:00:59]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-10-01 02:02:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617883007/1

[commit-bot: I haz the power, 2014-10-01 03:17:19]

Committed patchset #1 (id:1) as e6cac1d14c5db81485d6d71ddcb62307f058eb30

[commit-bot: I haz the power, 2014-10-01 03:17:51]

Patchset 1 (id:??) landed as
https://crrev.com/54f860ff71db682e634fe6fd813b1e6710d13a91
Cr-Commit-Position: refs/heads/master@{#297590}

[tapted, 2014-10-01 07:05:42]

Are you still investigating here? There are widespread failures of tests

testDropFromOutsideSource
testDropToReorder

e.g. on Mac 10.7
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg...
linux:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...

errors like

[7764:70403:0930/222542:INFO:CONSOLE(1283)] "Running TestCase
StartupPageListWebUITest.testDropFromOutsideSource", source: test_api.js (1283)
ASSERTION FAILED: !document().isActive() || !document().childNeedsStyleRecalc()
../../third_party/WebKit/Source/core/dom/Element.cpp(244) : virtual bool
blink::Element::rendererIsFocusable() const
1   0x1415cc4c blink::Element::rendererIsFocusable() const
2   0x141689be blink::Element::isFocusable() const
3   0x140b92e4
blink::Document::setFocusedElement(WTF::PassRefPtr\u003Cblink::Element>,
blink::FocusType)
4   0x150830e0 blink::FocusController::setFocusedElement(blink::Element*,
WTF::PassRefPtr\u003Cblink::Frame>, blink::FocusType)
5   0x1416880b blink::Element::focus(bool, blink::FocusType)
6   0x1358bd2d
_ZN5blink17ElementV8InternalL11focusMethodERKN2v820FunctionCallbackInfoINS1_5ValueEEE
7   0x13586e8a
_ZN5blink17ElementV8InternalL19focusMethodCallbackERKN2v820FunctionCallbackInfoINS1_5ValueEEE
8   0x10ba5391 v8::internal::FunctionCallbackArguments::Call(void
(*)(v8::FunctionCallbackInfo\u003Cv8::Value> const&))
9   0x10c0ad85
_ZN2v88internalL21Builtin_HandleApiCallEiPPNS0_6ObjectEPNS0_7IsolateE
10  0x37a0a2b6
11  0x2b1fd60a
BrowserTestBase signal handler received SIGTERM. Backtrace:

Looks like a tricky revert now...

[Vitaly Pavlenko, 2014-10-01 17:43:42]

On 2014/10/01 07:05:42, tapted wrote:
> Are you still investigating here? There are widespread failures of tests
> 
> testDropFromOutsideSource
> testDropToReorder
> 
> e.g. on Mac 10.7
>
http://build.chromium.org/p/chromium.mac/builders/Mac%2010.7%20Tests%20%28dbg...
> linux:
>
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29...
> 
> errors like
> 
> [7764:70403:0930/222542:INFO:CONSOLE(1283)] "Running TestCase
> StartupPageListWebUITest.testDropFromOutsideSource", source: test_api.js
(1283)
> ASSERTION FAILED: !document().isActive() ||
!document().childNeedsStyleRecalc()
> ../../third_party/WebKit/Source/core/dom/Element.cpp(244) : virtual bool
> blink::Element::rendererIsFocusable() const
> 1   0x1415cc4c blink::Element::rendererIsFocusable() const
> 2   0x141689be blink::Element::isFocusable() const
> 3   0x140b92e4
> blink::Document::setFocusedElement(WTF::PassRefPtr\u003Cblink::Element>,
> blink::FocusType)
> 4   0x150830e0 blink::FocusController::setFocusedElement(blink::Element*,
> WTF::PassRefPtr\u003Cblink::Frame>, blink::FocusType)
> 5   0x1416880b blink::Element::focus(bool, blink::FocusType)
> 6   0x1358bd2d
>
_ZN5blink17ElementV8InternalL11focusMethodERKN2v820FunctionCallbackInfoINS1_5ValueEEE
> 7   0x13586e8a
>
_ZN5blink17ElementV8InternalL19focusMethodCallbackERKN2v820FunctionCallbackInfoINS1_5ValueEEE
> 8   0x10ba5391 v8::internal::FunctionCallbackArguments::Call(void
> (*)(v8::FunctionCallbackInfo\u003Cv8::Value> const&))
> 9   0x10c0ad85
> _ZN2v88internalL21Builtin_HandleApiCallEiPPNS0_6ObjectEPNS0_7IsolateE
> 10  0x37a0a2b6
> 11  0x2b1fd60a
> BrowserTestBase signal handler received SIGTERM. Backtrace:
> 
> Looks like a tricky revert now...

Nope, I haven't investigated the test failures on their own. I only added this
debug because I wanted my another unrelated patch to be committed, and these
unrelated tests unfairly blocked me for some time.