Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 617883003: Fix the CommandLine for the WebView (Closed)

Created:
6 years, 2 months ago by hjd
Modified:
6 years, 2 months ago
Reviewers:
mkosiba (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the CommandLine for the WebView The CookieManager startup path needs access to the CommandLine before initialization. BUG=331424 Committed: https://crrev.com/12c017124f188e2b2e56c3b1a68e2cf9d62fcf96 Cr-Commit-Position: refs/heads/master@{#297469}

Patch Set 1 #

Patch Set 2 : Fix test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M android_webview/java/src/org/chromium/android_webview/AwBrowserProcess.java View 1 chunk +4 lines, -0 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/CommandLineTest.java View 1 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hjd
ptal
6 years, 2 months ago (2014-09-30 16:52:25 UTC) #2
mkosiba (inactive)
lgtm
6 years, 2 months ago (2014-09-30 16:56:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617883003/20001
6 years, 2 months ago (2014-09-30 17:13:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/20378)
6 years, 2 months ago (2014-09-30 17:26:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617883003/20001
6 years, 2 months ago (2014-09-30 18:33:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as e1c599da303e8bb54cc461fa88a82cd5f0d5e0d8
6 years, 2 months ago (2014-09-30 18:59:04 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:59:44 UTC) #11
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/12c017124f188e2b2e56c3b1a68e2cf9d62fcf96
Cr-Commit-Position: refs/heads/master@{#297469}

Powered by Google App Engine
This is Rietveld 408576698