Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 617883002: Revert of Disabling WebRtcBrowserTest.CallWithDataAndMedia (Closed)

Created:
6 years, 2 months ago by phoglund_chromium
Modified:
6 years, 2 months ago
Reviewers:
perkj_chrome, trchen
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Visibility:
Public.

Description

Revert of Disabling WebRtcBrowserTest.CallWithDataAndMedia (patchset #1 id:1 of https://codereview.chromium.org/290633003/) Reason for revert: Speculative re-enable. Original issue's description: > Disabling WebRtcBrowserTest.CallWithDataAndMedia > > WebRtcBrowserTest.CallWithDataAndMedia is flaking on Android Tests (dbg). > > BUG=374034 > TBR=perkj > NOTRY=true > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270888 TBR=perkj@chromium.org,trchen@chromium.org NOTREECHECKS=true NOTRY=true BUG=374034

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/media/webrtc_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
phoglund_chromium
Created Revert of Disabling WebRtcBrowserTest.CallWithDataAndMedia
6 years, 2 months ago (2014-09-30 15:01:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617883002/1
6 years, 2 months ago (2014-09-30 15:02:39 UTC) #2
commit-bot: I haz the power
Failed to apply patch for content/browser/media/webrtc_browsertest.cc: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-09-30 15:03:12 UTC) #4
phoglund_chromium
6 years, 2 months ago (2014-09-30 15:20:49 UTC) #5
On 2014/09/30 15:03:12, I haz the power (commit-bot) wrote:
> Failed to apply patch for content/browser/media/webrtc_browsertest.cc:
> While running git apply --index -3 -p1;
>   error: patch failed: content/browser/media/webrtc_browsertest.cc:247
>   Falling back to three-way merge...
>   Applied patch to 'content/browser/media/webrtc_browsertest.cc' with
conflicts.
>   U content/browser/media/webrtc_browsertest.cc
> 
> Patch:       content/browser/media/webrtc_browsertest.cc
> Index: content/browser/media/webrtc_browsertest.cc
> diff --git a/content/browser/media/webrtc_browsertest.cc
> b/content/browser/media/webrtc_browsertest.cc
> index
>
f6aefa6e6aa2799c8f1621817615a6e91d2fcb7a..7377b0401f4e7ecbbc596c963fa99d0984cad828
> 100644
> --- a/content/browser/media/webrtc_browsertest.cc
> +++ b/content/browser/media/webrtc_browsertest.cc
> @@ -247,7 +247,7 @@
>  // This test will make a PeerConnection-based call and test an unreliable
text
>  // dataChannel and audio and video tracks.
>  // TODO(mallinath) - Remove this test after rtp based data channel is
disabled.
> -IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, DISABLED_CallWithDataAndMedia) {
> +IN_PROC_BROWSER_TEST_P(WebRtcBrowserTest, MAYBE_CallWithDataAndMedia) {
>    MakeTypicalPeerConnectionCall("callWithDataAndMedia();");
>  }

Alright, made https://codereview.chromium.org/612413003/ instead.

Powered by Google App Engine
This is Rietveld 408576698