Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 617853002: [turbofan] Add BoundsCheckMode to ElementAccess. (Closed)

Created:
6 years, 2 months ago by Benedikt Meurer
Modified:
6 years, 2 months ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Add BoundsCheckMode to ElementAccess. This is currently only used for StoreElement. LoadElement will be updated to make use of that in a follow-up CL (depends on additional control input for loads first). TEST=cctest,mjsunit R=jarin@chromium.org, mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24347

Patch Set 1 #

Patch Set 2 : Fix invalid bounds check. #

Total comments: 1

Patch Set 3 : Fix test #

Patch Set 4 : Rename #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -86 lines) Patch
M src/compiler/access-builder.cc View 1 2 3 2 chunks +19 lines, -10 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 1 chunk +3 lines, -17 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 3 1 chunk +35 lines, -6 lines 0 comments Download
M src/compiler/simplified-operator.h View 1 2 3 2 chunks +8 lines, -0 lines 0 comments Download
M src/compiler/simplified-operator.cc View 1 2 3 3 chunks +15 lines, -1 line 0 comments Download
M src/compiler/simplified-operator-unittest.cc View 1 2 3 1 chunk +38 lines, -37 lines 0 comments Download
M test/cctest/compiler/test-simplified-lowering.cc View 9 chunks +21 lines, -15 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years, 2 months ago (2014-09-30 12:54:48 UTC) #1
Jarin
lgtm. https://codereview.chromium.org/617853002/diff/20001/src/compiler/simplified-operator.h File src/compiler/simplified-operator.h (right): https://codereview.chromium.org/617853002/diff/20001/src/compiler/simplified-operator.h#newcode49 src/compiler/simplified-operator.h:49: enum BoundsCheckMode { kNoBoundsCheck, kIgnoreOutOfBounds }; The kIgnoreOutOfBounds ...
6 years, 2 months ago (2014-10-01 07:31:51 UTC) #3
Benedikt Meurer
6 years, 2 months ago (2014-10-01 07:43:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 (id:40002) manually as 24347.

Powered by Google App Engine
This is Rietveld 408576698