Remove --install-from-webstore and --limited-install-from-webstore

Remove --install-from-webstore and --limited-install-from-webstore

Both these switches should be removed, as they allow malware
to potentially install extensions on a user's computer.
Since the --install-from-webstore switch is also being used
to install ephemeral apps, rename it to
--install-ephemeral-app-from-webstore, and ensure that this
only works on installed ephemeral apps on Windows. (This
has sufficient checks in place, such as an extension of
the same ID already being installed, that this is safe.)

BUG=410833
Committed: https://crrev.com/462b2fbc2e486d47ab682770418fa6deacfe67be
Cr-Commit-Position: refs/heads/master@{#297868}

[Devlin, 2014-10-01 17:14:20]

Patchset #2 (id:20001) has been deleted

[Devlin, 2014-10-01 17:14:27]

Patchset #1 (id:1) has been deleted

[Devlin, 2014-10-01 17:20:00]

Patchset #1 (id:40001) has been deleted

[Devlin, 2014-10-01 17:25:42]

rdevlin.cronin@chromium.org changed reviewers:
+ tapted@chromium.org, yoz@chromium.org

[Devlin, 2014-10-01 17:25:43]

Trent and Yoyo, can you take a look?

[Yoyo Zhou, 2014-10-01 20:41:09]

LGTM; are all the ephemeral apps folks aware of this change?

[Devlin, 2014-10-01 20:43:50]

On 2014/10/01 20:41:09, Yoyo Zhou wrote:
> LGTM; are all the ephemeral apps folks aware of this change?

Chatted with Ben Wells briefly over email about whether or not the switch could
truly be removed, but he said they'd like to keep using it for the windows jump
list.  So the ephemeral app functionality should be untouched.  To verify this,
Trent (OWNER from views/apps) is also on the CL. :)

[tapted, 2014-10-02 01:48:17]

On 2014/10/01 20:43:50, Devlin wrote:
> On 2014/10/01 20:41:09, Yoyo Zhou wrote:
> > LGTM; are all the ephemeral apps folks aware of this change?
> 
> Chatted with Ben Wells briefly over email about whether or not the switch
could
> truly be removed, but he said they'd like to keep using it for the windows
jump
> list.  So the ephemeral app functionality should be untouched.  To verify
this,
> Trent (OWNER from views/apps) is also on the CL. :)

lgtm - And that's correct - ephemeral apps still need it for the jump list. And
this change looks good. (my only concern is that
"nckgahadagoaajjgafhacjanaoiihapd" is hangouts and there might be something
really obscure and hidden still using -limited-install-from-webstore, but I'm
sure you've checked that already, and I couldn't find anything).

[Devlin, 2014-10-02 15:30:25]

rdevlin.cronin@chromium.org changed reviewers:
+ levin@chromium.org

[Devlin, 2014-10-02 15:30:38]

On 2014/10/02 01:48:17, tapted wrote:
> On 2014/10/01 20:43:50, Devlin wrote:
> > On 2014/10/01 20:41:09, Yoyo Zhou wrote:
> > > LGTM; are all the ephemeral apps folks aware of this change?
> > 
> > Chatted with Ben Wells briefly over email about whether or not the switch
> could
> > truly be removed, but he said they'd like to keep using it for the windows
> jump
> > list.  So the ephemeral app functionality should be untouched.  To verify
> this,
> > Trent (OWNER from views/apps) is also on the CL. :)
> 
> lgtm - And that's correct - ephemeral apps still need it for the jump list.
And
> this change looks good. (my only concern is that
> "nckgahadagoaajjgafhacjanaoiihapd" is hangouts and there might be something
> really obscure and hidden still using -limited-install-from-webstore, but I'm
> sure you've checked that already, and I couldn't find anything).

--limited-install-from-webstore was previously used by hangouts in order to
install itself, but they've since moved off this flow, and levin@ has said it's
safe to remove.  Just to confirm, though, +David.

[levin, 2014-10-02 15:49:24]

> --limited-install-from-webstore was previously used by hangouts in order to
> install itself, but they've since moved off this flow, and levin@ has said
it's
> safe to remove.  Just to confirm, though, +David.

Thanks. Yes, it is safe to remove. Make it so.

[Devlin, 2014-10-02 15:54:00]

rdevlin.cronin@chromium.org changed reviewers:
+ sky@chromium.org

[Devlin, 2014-10-02 15:54:01]

+sky@ for c/b/ui/startup/ (just slightly too big for a TBR).

[sky, 2014-10-02 17:23:34]

LGTM

[Devlin, 2014-10-02 17:26:49]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-10-02 17:27:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617833003/60001

[commit-bot: I haz the power, 2014-10-02 18:33:03]

Committed patchset #1 (id:60001) as 1efac76a5b2930f5c9627cb80f0f6bb22b41e9e6

[commit-bot: I haz the power, 2014-10-02 18:35:08]

Patchset 1 (id:??) landed as
https://crrev.com/462b2fbc2e486d47ab682770418fa6deacfe67be
Cr-Commit-Position: refs/heads/master@{#297868}