Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: Source/devtools/front_end/components/DockController.js

Issue 617783002: Fix incorrect tooltip displayed for dock icon in "Dev Tools". (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 AfterDockSideChanged: "AfterDockSideChanged" 62 AfterDockSideChanged: "AfterDockSideChanged"
63 } 63 }
64 64
65 WebInspector.DockController.prototype = { 65 WebInspector.DockController.prototype = {
66 initialize: function() 66 initialize: function()
67 { 67 {
68 if (!this._canDock) 68 if (!this._canDock)
69 return; 69 return;
70 70
71 this._states = [WebInspector.DockController.State.DockedToRight, WebInsp ector.DockController.State.DockedToBottom, WebInspector.DockController.State.Und ocked]; 71 this._states = [WebInspector.DockController.State.DockedToRight, WebInsp ector.DockController.State.DockedToBottom, WebInspector.DockController.State.Und ocked];
72 this._titles = [WebInspector.UIString("Dock to main window."), WebInspec tor.UIString("Undock into separate window."), WebInspector.UIString("Dock to mai n window.")]; 72 this._titles = [WebInspector.UIString("Dock to main window."), WebInspec tor.UIString("Dock to main window."), WebInspector.UIString("Undock into separat e window.")];
73 if (Runtime.experiments.isEnabled("dockToLeft")) { 73 if (Runtime.experiments.isEnabled("dockToLeft")) {
74 this._states.push(WebInspector.DockController.State.DockedToLeft); 74 this._states.push(WebInspector.DockController.State.DockedToLeft);
75 this._titles.push(WebInspector.UIString("Dock to main window.")); 75 this._titles.push(WebInspector.UIString("Dock to main window."));
76 } 76 }
77 var initialState = WebInspector.settings.currentDockState.get(); 77 var initialState = WebInspector.settings.currentDockState.get();
78 initialState = this._states.indexOf(initialState) >= 0 ? initialState : this._states[0]; 78 initialState = this._states.indexOf(initialState) >= 0 ? initialState : this._states[0];
79 this._dockSideChanged(initialState); 79 this._dockSideChanged(initialState);
80 }, 80 },
81 81
82 /** 82 /**
(...skipping 107 matching lines...) Expand 10 before | Expand all | Expand 10 after
190 WebInspector.dockController._dockSideChanged.bind(WebInspect or.dockController)); 190 WebInspector.dockController._dockSideChanged.bind(WebInspect or.dockController));
191 } 191 }
192 return this._dockToggleButton; 192 return this._dockToggleButton;
193 } 193 }
194 } 194 }
195 195
196 /** 196 /**
197 * @type {!WebInspector.DockController} 197 * @type {!WebInspector.DockController}
198 */ 198 */
199 WebInspector.dockController; 199 WebInspector.dockController;
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698