Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 617743004: Fix MediaPlayerBridge to handle unknown or infinite durations. (Closed)

Created:
6 years, 2 months ago by DaleCurtis
Modified:
6 years, 2 months ago
Reviewers:
qinmin
CC:
chromium-reviews, feature-media-reviews_chromium.org, avayvod+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix MediaPlayerBridge to handle unknown or infinite durations. The Android MediaPlayer API says it will return -1 for the duration if it is unknown: http://developer.android.com/reference/android/media/MediaPlayer.html#getDuration() The Chrome media pipeline expects this to be presented as media::kInfiniteDuration() when in TimeDelta format. BUG=none TEST=none Committed: https://crrev.com/a417a417a23c24bbc0136e069ad93a945b15ba66 Cr-Commit-Position: refs/heads/master@{#297556}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M media/base/android/media_player_bridge.cc View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
DaleCurtis
I guess https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/LayoutTests/media/video-buffered-unknown-duration.html isn't running on Android?
6 years, 2 months ago (2014-09-30 22:14:06 UTC) #2
qinmin
lgtm. There is no bots running layout tests when I checked it several weeks ago, ...
6 years, 2 months ago (2014-09-30 22:29:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617743004/1
6 years, 2 months ago (2014-09-30 23:26:47 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as e60d25dec9d47a926053cae8c3bf6045653019ed
6 years, 2 months ago (2014-10-01 00:20:36 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 00:21:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a417a417a23c24bbc0136e069ad93a945b15ba66
Cr-Commit-Position: refs/heads/master@{#297556}

Powered by Google App Engine
This is Rietveld 408576698