Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 617723004: Add a MultiPictureDraw GM to exercise layer clipping (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add a MultiPictureDraw GM to exercise layer clipping This adds a "biglayer" variant that creates a picture with a single big layer. The tiling composition will test whether the layer hoisting code correctly caches the layers with their clipping information. BUG=skia:2315 Committed: https://skia.googlesource.com/skia/+/b1fc64b8faa17a1d7fc7140dc18906b639fbd27b

Patch Set 1 #

Patch Set 2 : Add MultiPictureDraw-based GM to exercise clipped layers #

Patch Set 3 : Fix overlength line #

Patch Set 4 : Add comment to clarify GM behavior #

Total comments: 1

Patch Set 5 : Removed stray '\n' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -4 lines) Patch
M gm/multipicturedraw.cpp View 1 2 3 4 8 chunks +66 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
robertphillips
6 years, 2 months ago (2014-10-01 15:42:27 UTC) #2
robertphillips
ping - I have added a clarifying comment
6 years, 2 months ago (2014-10-02 12:30:59 UTC) #3
egdaniel
lgtm + nit https://codereview.chromium.org/617723004/diff/60001/gm/multipicturedraw.cpp File gm/multipicturedraw.cpp (right): https://codereview.chromium.org/617723004/diff/60001/gm/multipicturedraw.cpp#newcode131 gm/multipicturedraw.cpp:131: extra \n
6 years, 2 months ago (2014-10-02 13:03:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617723004/80001
6 years, 2 months ago (2014-10-02 15:24:38 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 15:32:49 UTC) #7
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as b1fc64b8faa17a1d7fc7140dc18906b639fbd27b

Powered by Google App Engine
This is Rietveld 408576698