Issue 617703002: Disable tabs/windows API on athena

Issue 617703002: Disable tabs/windows API on athena (Closed)

Created:
6 years, 2 months ago by oshima

Modified:
6 years, 2 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Disable tabs/windows API on athena BUG=414340 R=yoz@chromium.org Committed: https://crrev.com/9100646e2c0391a080fe53f16c732b3045f9c468 Cr-Commit-Position: refs/heads/master@{#297515}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+365 lines, -0 lines)			Patch
	A	chrome/browser/extensions/api/tabs/tabs_api_athena.cc	View		1 chunk	+360 lines, -0 lines	0 comments	Download
	M	chrome/chrome_browser_extensions.gypi	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 9 (3 generated)

oshima

This is alternative way to https://codereview.chromium.org/607603002/

6 years, 2 months ago (2014-09-30 13:25:11 UTC) #2

Yoyo Zhou

LGTM, not sure if we need to validate all the params though if we're just ...

6 years, 2 months ago (2014-09-30 21:46:34 UTC) #4

oshima

On 2014/09/30 21:46:34, Yoyo Zhou wrote: > LGTM, not sure if we need to validate ...

6 years, 2 months ago (2014-09-30 21:51:58 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617703002/40001

6 years, 2 months ago (2014-09-30 21:53:50 UTC) #7

commit-bot: I haz the power

Committed patchset #1 (id:40001) as 0396f40775348761328f463f40e7f13c595356f4

6 years, 2 months ago (2014-09-30 22:00:15 UTC) #8

commit-bot: I haz the power

6 years, 2 months ago (2014-09-30 22:01:18 UTC) #9

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9100646e2c0391a080fe53f16c732b3045f9c468
Cr-Commit-Position: refs/heads/master@{#297515}