Issue 617673002: history: fix closure compilation by fixing non-standardized use of setInterval().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 617673002: history: fix closure compilation by fixing non-standardized use of setInterval(). (Closed)

Created:
6 years, 2 months ago by Dan Beam

Modified:
6 years, 2 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

history: fix closure compilation by fixing non-standardized use of setInterval(). BUG=393873 R=estade@chromium.org Committed: https://crrev.com/558c328a3f5a49f3e3b1b3e04f71aa3ab78326b3 Cr-Commit-Position: refs/heads/master@{#297344}

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	chrome/browser/resources/history/history.js	View	1	1 chunk	+8 lines, -8 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617673002/20001

6 years, 2 months ago (2014-09-30 02:00:10 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (id:20001) as de65149368c2a188ded2eb0ba656dd59b34d5c35

6 years, 2 months ago (2014-09-30 02:36:41 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-09-30 02:37:22 UTC) #6

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/558c328a3f5a49f3e3b1b3e04f71aa3ab78326b3
Cr-Commit-Position: refs/heads/master@{#297344}