Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 61763026: Move chrome/browser/nacl_host/pnacl_translation_cache.* to components/nacl/browser (Closed)

Created:
7 years, 1 month ago by darktears
Modified:
7 years, 1 month ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Move chrome/browser/nacl_host/pnacl_translation_cache.* to components/nacl/browser These files have no dependencies on chrome/ so they can be safely moved to the components/ directory. This is part of an effort to componentize NaCl code. BUG=244791 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=235735

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -828 lines) Patch
M chrome/browser/nacl_host/pnacl_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/pnacl_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/nacl_host/pnacl_translation_cache.h View 1 chunk +0 lines, -106 lines 0 comments Download
D chrome/browser/nacl_host/pnacl_translation_cache.cc View 1 chunk +0 lines, -440 lines 0 comments Download
D chrome/browser/nacl_host/pnacl_translation_cache_unittest.cc View 1 chunk +0 lines, -269 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_common.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M components/components_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M components/nacl.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M components/nacl/browser/DEPS View 1 chunk +2 lines, -0 lines 0 comments Download
A + components/nacl/browser/pnacl_translation_cache.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + components/nacl/browser/pnacl_translation_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
A + components/nacl/browser/pnacl_translation_cache_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/nacl_common.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
darktears
7 years, 1 month ago (2013-11-14 18:22:48 UTC) #1
darktears
On 2013/11/14 18:22:48, darktears wrote: @Mark : It's ready for review.
7 years, 1 month ago (2013-11-14 20:45:34 UTC) #2
Mark Seaborn
LGTM
7 years, 1 month ago (2013-11-14 22:12:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/61763026/1
7 years, 1 month ago (2013-11-15 03:56:33 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=36490
7 years, 1 month ago (2013-11-15 05:33:37 UTC) #5
darktears
I need a rubber stamp on the net/ dependency.
7 years, 1 month ago (2013-11-15 10:16:34 UTC) #6
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-15 16:10:58 UTC) #7
agl
I'm here as a net/ OWNERS, but I don't see anything that needs my approval. ...
7 years, 1 month ago (2013-11-15 16:22:08 UTC) #8
Mark Seaborn
On 2013/11/15 16:22:08, agl wrote: > I'm here as a net/ OWNERS, but I don't ...
7 years, 1 month ago (2013-11-15 16:44:49 UTC) #9
szym
new dependency LGTM
7 years, 1 month ago (2013-11-15 20:58:08 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexis.menard@intel.com/61763026/1
7 years, 1 month ago (2013-11-18 11:44:12 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-18 16:26:13 UTC) #12
Message was sent while issue was closed.
Change committed as 235735

Powered by Google App Engine
This is Rietveld 408576698