Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 61763010: Move WebInbandTextTrack/WebInbandTextTrackClient to public/platform/ (Closed)

Created:
7 years, 1 month ago by philipj_slow
Modified:
7 years, 1 month ago
CC:
blink-reviews, jamesr, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Move WebInbandTextTrack/WebInbandTextTrackClient to public/platform/ This is to allow InbandTextTrackPrivate/InbandTextTrackPrivateClient to be removed, by using the Web* variants directly, and for that to be allowed they must reside in public/platform/. Some style changes were required to please presubmit. BUG=316172 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161626

Patch Set 1 #

Patch Set 2 : allow the include #

Total comments: 2

Patch Set 3 : use specific_include_rules #

Total comments: 4

Patch Set 4 : simplify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -69 lines) Patch
A + public/platform/WebInbandTextTrack.h View 1 chunk +1 line, -1 line 0 comments Download
A + public/platform/WebInbandTextTrackClient.h View 1 chunk +2 lines, -6 lines 0 comments Download
M public/web/WebInbandTextTrack.h View 1 2 3 1 chunk +1 line, -41 lines 0 comments Download
M public/web/WebInbandTextTrackClient.h View 1 2 3 1 chunk +1 line, -21 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
philipj_slow
I've talked to Jochen about this on IRC, but it sounded like he wanted Adam ...
7 years, 1 month ago (2013-11-07 15:06:12 UTC) #1
philipj_slow
See https://chromiumcodereview.appspot.com/60083011/ for more context.
7 years, 1 month ago (2013-11-07 15:06:48 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/61763010/diff/30001/public/web/DEPS File public/web/DEPS (right): https://codereview.chromium.org/61763010/diff/30001/public/web/DEPS#newcode1 public/web/DEPS:1: include_rules = [ can you use specific_include_rules to restrict ...
7 years, 1 month ago (2013-11-07 15:23:12 UTC) #3
philipj_slow
https://codereview.chromium.org/61763010/diff/30001/public/web/DEPS File public/web/DEPS (right): https://codereview.chromium.org/61763010/diff/30001/public/web/DEPS#newcode1 public/web/DEPS:1: include_rules = [ On 2013/11/07 15:23:12, jochen wrote: > ...
7 years, 1 month ago (2013-11-07 15:39:31 UTC) #4
abarth-chromium
https://codereview.chromium.org/61763010/diff/90001/public/web/DEPS File public/web/DEPS (right): https://codereview.chromium.org/61763010/diff/90001/public/web/DEPS#newcode8 public/web/DEPS:8: ] There's no need for these rules. https://codereview.chromium.org/61763010/diff/90001/public/web/WebInbandTextTrack.h File ...
7 years, 1 month ago (2013-11-07 18:25:22 UTC) #5
philipj_slow
https://codereview.chromium.org/61763010/diff/90001/public/web/DEPS File public/web/DEPS (right): https://codereview.chromium.org/61763010/diff/90001/public/web/DEPS#newcode8 public/web/DEPS:8: ] On 2013/11/07 18:25:22, abarth wrote: > There's no ...
7 years, 1 month ago (2013-11-07 19:42:03 UTC) #6
philipj_slow
s/name/many/
7 years, 1 month ago (2013-11-07 19:58:09 UTC) #7
abarth-chromium
On 2013/11/07 19:42:03, philipj wrote: > https://codereview.chromium.org/61763010/diff/90001/public/web/DEPS > File public/web/DEPS (right): > > https://codereview.chromium.org/61763010/diff/90001/public/web/DEPS#newcode8 > ...
7 years, 1 month ago (2013-11-07 22:02:12 UTC) #8
abarth-chromium
On 2013/11/07 19:42:03, philipj wrote: > I was tricked by the name other files in ...
7 years, 1 month ago (2013-11-07 22:03:01 UTC) #9
philipj_slow
On 2013/11/07 22:03:01, abarth wrote: > On 2013/11/07 19:42:03, philipj wrote: > > I was ...
7 years, 1 month ago (2013-11-07 23:34:03 UTC) #10
jochen (gone - plz use gerrit)
lgtm
7 years, 1 month ago (2013-11-08 11:31:12 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/61763010/160001
7 years, 1 month ago (2013-11-08 13:38:59 UTC) #12
commit-bot: I haz the power
7 years, 1 month ago (2013-11-08 15:21:12 UTC) #13
Message was sent while issue was closed.
Change committed as 161626

Powered by Google App Engine
This is Rietveld 408576698