Add EmbeddedWorker interfaces in Blink API

public/web/WebServiceWorkerContextClient.h

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 10 matching lines @@
  * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
  * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
  * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
  * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
  * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
  * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
  * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-#ifndef WorkerPermissionClient_h
-#define WorkerPermissionClient_h
+#ifndef WebServiceWorkerContextClient_h
+#define WebServiceWorkerContextClient_h
 
-#include "core/workers/WorkerClients.h"
-#include "wtf/Forward.h"
-
-namespace WebCore {
-class ExecutionContext;
-}
+#include "WebWorkerPermissionClientProxy.h"
 
 namespace blink {
 
-class WebFrame;
 class WebString;
-class WebWorkerPermissionClientProxy;
+class WebServiceWorkerContextProxy;
 
-class WorkerPermissionClient : public WebCore::Supplement<WebCore::WorkerClients> {
+// This interface is implemented by the client. It is suppoed to be created
+// on the main thread and then passed on to the worker thread to be owned
+// by a newly created WorkerGlobalScope. All methods of this class are
+// called on the worker thread.
+class WebServiceWorkerContextClient : public WebWorkerPermissionClientProxy {

[michaeln, 2013/11/12 22:50:00]

This derivation seems odd to me too, its not a generalization/specialization
really.

[kinuko, 2013/11/18 10:41:13]

No. I wanted to make this class as a collection of client interfaces, like
WorkerPermissionClientProxy, WorkerReportingClientProxy and
WorkerServiceWorkerGlobalScopeClientProxy.

We can't simply let implementation inherit them by multiple inheritance because
these client instances are basically intended to be owned by WorkerGlobalScope.

For clearer interfaces I removed this inheritance anyway (which means we'll have
separate implementations for them in chromium side too).

 public:
-    static PassOwnPtr<WorkerPermissionClient> create(PassOwnPtr<WebWorkerPermissionClientProxy>);
+    // A new WorkerGlobalScope is created and started to run on the
+    // worker thread.
+    // This also gives back a proxy to the client to talk to the
+    // newly created WorkerGlobalScope. The proxy is held by WorkerGlobalScope
+    // and should not be held by the caller. No proxy methods should be called
+    // after workerContextDestroyed() is called.
+    virtual void workerContextStarted(WebServiceWorkerContextProxy*) { }
 
-    virtual ~WorkerPermissionClient();
+    // WorkerGlobalScope.close() is called.
+    virtual void workerContextClosed() { }
 
-    bool allowDatabase(const WebString& name, const WebString& displayName, unsigned long estimatedSize);
-    bool allowFileSystem();
-    bool allowIndexedDB(const WebString& name);
+    // WorkerGlobalScope is destroyed. The client should clear the
+    // WebServiceWorkerGlobalScopeProxy when this is called.
+    virtual void workerContextDestroyed() { }
 
-    static const char* supplementName();
-    static WorkerPermissionClient* from(WebCore::ExecutionContext*);
-
-private:
-    explicit WorkerPermissionClient(PassOwnPtr<WebWorkerPermissionClientProxy>);
-
-    OwnPtr<WebWorkerPermissionClientProxy> m_proxy;
+    virtual void dispatchDevToolsMessage(const WebString&) { }
+    virtual void saveDevToolsAgentState(const WebString&) { }
 };
 
-void providePermissionClientToWorker(WebCore::WorkerClients*, PassOwnPtr<WebWorkerPermissionClientProxy>);
-
 } // namespace blink
 
-#endif // WorkerPermissionClient_h
+#endif // WebWorkerContextClient_h