Issue 617613003: Speculative revert to diagnose crash in chrome. Revert "Add SkCachedData and use it for SkMipMap"

Issue 617613003: Speculative revert to diagnose crash in chrome. Revert "Add SkCachedData and use it for SkMipMap" (Closed)

Created:
6 years, 2 months ago by reed1

Modified:
6 years, 2 months ago

Reviewers:
mtklein

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Speculative revert to diagnose crash in chrome. Revert "Add SkCachedData and use it for SkMipMap" This reverts commit 92561a0b99ad6c08ab7a11dd1872f028199392e9. crasher in question: https://code.google.com/p/chromium/issues/detail?id=420178 Committed: https://skia.googlesource.com/skia/+/37c5a815d8ea33247968212ef4cc83394ceee1bc

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -522 lines)			Patch
M	gyp/core.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	gyp/tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/core/SkBitmapCache.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/core/SkBitmapCache.cpp	View	3 chunks	+13 lines, -25 lines	0 comments	Download
M	src/core/SkBitmapProcState.cpp	View	1 chunk	+2 lines, -1 line	0 comments	Download
D	src/core/SkCachedData.h	View	1 chunk	+0 lines, -107 lines	0 comments	Download
D	src/core/SkCachedData.cpp	View	1 chunk	+0 lines, -175 lines	0 comments	Download
M	src/core/SkMipMap.h	View	2 chunks	+8 lines, -15 lines	0 comments	Download
M	src/core/SkMipMap.cpp	View	4 chunks	+20 lines, -28 lines	0 comments	Download
M	src/core/SkResourceCache.h	View	3 chunks	+0 lines, -5 lines	0 comments	Download
M	src/core/SkResourceCache.cpp	View	3 chunks	+0 lines, -15 lines	0 comments	Download
D	tests/CachedDataTest.cpp	View	1 chunk	+0 lines, -95 lines	0 comments	Download
M	tests/MipMapTest.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/SkResourceCacheTest.cpp	View	2 chunks	+0 lines, -51 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617613003/1

6 years, 2 months ago (2014-10-03 19:51:42 UTC) #5

commit-bot: I haz the power

6 years, 2 months ago (2014-10-03 20:23:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 37c5a815d8ea33247968212ef4cc83394ceee1bc