src/IceTargetLoweringX8632.cpp - Issue 617593002: Handle imul, pcmpeq, pcmpgt.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8632.cpp

Issue 617593002: Handle imul, pcmpeq, pcmpgt. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: go ahead and optimize i8 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/IceTargetLoweringX8632.cpp

diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp

index 7a7fb120ab089505c8bc45391c808695212905fa..96cc57bf82767335af2ddece0dea58a910698042 100644

--- a/src/IceTargetLoweringX8632.cpp

+++ b/src/IceTargetLoweringX8632.cpp

@@ -1581,10 +1581,12 @@ void TargetX8632::lowerArithmetic(const InstArithmetic *Inst) {

// The 8-bit version of imul only allows the form "imul r/m8"

// where T must be in eax.

- if (isByteSizedArithType(Dest->getType()))

+ if (isByteSizedArithType(Dest->getType())) {

_mov(T, Src0, RegX8632::Reg_eax);

- else

+ Src1 = legalize(Src1, Legal_Reg | Legal_Mem);

Jim Stichnoth 2014/09/30 05:17:07 cool, thanks!

+ } else {

_mov(T, Src0);

+ }

_imul(T, Src1);

_mov(Dest, T);

break;

« no previous file with comments | « src/IceInstX8632.cpp ('k') | src/assembler_ia32.h » ('j') | no next file with comments »