Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 617573002: Remove jgraettinger@chromium.org as a net owner (Closed)

Created:
6 years, 2 months ago by mmenke
Modified:
5 years, 10 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, asvitkine+watch_chromium.org, cbentzel, Johnny
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove jgraettinger@chromium.org as a net owner as he no longer works on Chromium. Also transfer ownership of the histogram he owned. BUG=NONE NOTRY=true Committed: https://crrev.com/02b8c0f003548fc82d27e9806310f7f60d1f0bc8 Cr-Commit-Position: refs/heads/master@{#297425}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change new owner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M net/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
mmenke
Ryan: I asked Johnny about this before he left, and he indicated that this was ...
6 years, 2 months ago (2014-09-29 21:08:35 UTC) #2
mmenke
Oops: asvitkine: Please review histogram change.
6 years, 2 months ago (2014-09-29 21:08:55 UTC) #3
Ryan Hamilton
LGTM, modulo one suggested change. https://codereview.chromium.org/617573002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/617573002/diff/1/tools/metrics/histograms/histograms.xml#newcode17549 tools/metrics/histograms/histograms.xml:17549: + <owner>rch@chromium.org</owner> I think ...
6 years, 2 months ago (2014-09-29 21:14:58 UTC) #4
mmenke
+bnc: Transferring ownership of Johnny's histogram to you. Congratulations on your ownership of a pre-owned, ...
6 years, 2 months ago (2014-09-29 21:18:31 UTC) #6
Alexei Svitkine (slow)
lgtm
6 years, 2 months ago (2014-09-29 21:20:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617573002/20001
6 years, 2 months ago (2014-09-30 15:05:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4b0d02627cb805fbb4ca75edbec62599211f60eb
6 years, 2 months ago (2014-09-30 15:06:12 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 15:06:48 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/02b8c0f003548fc82d27e9806310f7f60d1f0bc8
Cr-Commit-Position: refs/heads/master@{#297425}

Powered by Google App Engine
This is Rietveld 408576698