Fix size and position of the virtual keyboard after a screen rotation.

Fix size and position of the virtual keyboard after a screen rotation.

This regression was introduced by commit #295268, which fixed the z-order of the virtual keyboards with respect to context menus.  That change pushed the virtual keyboard container deeper in the window hierarchy such that it no longer receives size change notifications after a screen rotation.

This patch introduces a custom layout manager on the virtual keyboard parent container to propagate the size change.  The virtual keyboard container is created or destroyed as the feature is enabled or disabled.  The parent container serves as a placeholder in the proper z-order.  The window hierarchy is: root -> lock screen related container -> VK parent container -> VK container -> VK.

BUG=417612
TEST=VirtualKeyboardRootWindowControllerTest.DisplayRotation

Committed: https://crrev.com/0e450495d30494943c2773c108b9234a00272a94
Cr-Commit-Position: refs/heads/master@{#297430}

[kevers, 2014-09-29 20:51:59]

kevers@chromium.org changed reviewers:
+ jamescook@chromium.org

[kevers, 2014-09-29 20:54:24]

Hi James,

Can you please take a look at this CL.

[James Cook, 2014-09-29 21:38:00]

LGTM with nits

https://codereview.chromium.org/617553002/diff/1/ash/root_window_controller_u...
File ash/root_window_controller_unittest.cc (right):

https://codereview.chromium.org/617553002/diff/1/ash/root_window_controller_u...
ash/root_window_controller_unittest.cc:956: ASSERT_EQ("0,0 800x600",
keyboard_container->bounds().ToString());
nit: EXPECT_EQ since the test can proceed even if the expectation fails

https://codereview.chromium.org/617553002/diff/1/ash/root_window_controller_u...
ash/root_window_controller_unittest.cc:960: }
nice easy-to-read test

https://codereview.chromium.org/617553002/diff/1/ash/wm/virtual_keyboard_cont...
File ash/wm/virtual_keyboard_container_layout_manager.cc (right):

https://codereview.chromium.org/617553002/diff/1/ash/wm/virtual_keyboard_cont...
ash/wm/virtual_keyboard_container_layout_manager.cc:37: // update when its
parent is resized.
nit: updated

https://codereview.chromium.org/617553002/diff/1/ash/wm/virtual_keyboard_cont...
File ash/wm/virtual_keyboard_container_layout_manager.h (right):

https://codereview.chromium.org/617553002/diff/1/ash/wm/virtual_keyboard_cont...
ash/wm/virtual_keyboard_container_layout_manager.h:8: #include
"ash/snap_to_pixel_layout_manager.h"
nit: #include "base/macros.h" for DISALLOW_COPY_AND_ASSIGN

https://codereview.chromium.org/617553002/diff/1/ash/wm/virtual_keyboard_cont...
ash/wm/virtual_keyboard_container_layout_manager.h:21: // Overridden from
SnapToPixelLayoutManager:
nit: indent

[kevers, 2014-09-30 13:41:13]

The CQ bit was checked by kevers@chromium.org

[commit-bot: I haz the power, 2014-09-30 13:42:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617553002/40001

[commit-bot: I haz the power, 2014-09-30 14:58:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 14:58:44]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[kevers, 2014-09-30 15:22:13]

The CQ bit was checked by kevers@chromium.org

[commit-bot: I haz the power, 2014-09-30 15:23:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/617553002/60001

[commit-bot: I haz the power, 2014-09-30 16:02:39]

Committed patchset #4 (id:60001) as 747fa7e146666c212b402871e4c6be1faa339c77

[commit-bot: I haz the power, 2014-09-30 16:03:17]

Patchset 4 (id:??) landed as
https://crrev.com/0e450495d30494943c2773c108b9234a00272a94
Cr-Commit-Position: refs/heads/master@{#297430}