Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 617533002: Make http result code histograms show the value too. (Closed)

Created:
6 years, 2 months ago by Alexei Svitkine (slow)
Modified:
6 years, 2 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Make http result code histograms show the value too. Often, when looking at histograms using these, it's much easier to go by the code than the name, so show both. BUG=none NOTRY=true Committed: https://crrev.com/f172268a30fc43a836a80fc68d7ce242ddcd05d0 Cr-Commit-Position: refs/heads/master@{#297259}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +40 lines, -40 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Alexei Svitkine (slow)
6 years, 2 months ago (2014-09-29 20:18:29 UTC) #2
Ilya Sherman
LGTM, thanks.
6 years, 2 months ago (2014-09-29 21:02:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617533002/1
6 years, 2 months ago (2014-09-29 21:04:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6e3839010f9ffb3d8402156e1e481b7e10bdedb1
6 years, 2 months ago (2014-09-29 21:07:21 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 21:09:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f172268a30fc43a836a80fc68d7ce242ddcd05d0
Cr-Commit-Position: refs/heads/master@{#297259}

Powered by Google App Engine
This is Rietveld 408576698