Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: tests/lib/mirrors/private_symbol_test.dart

Issue 61753019: Allow creation of public symbols using MirrorSystem.getSymbol when passing a null library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/lib/mirrors_patch.dart ('K') | « runtime/lib/mirrors_patch.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/private_symbol_test.dart
diff --git a/tests/lib/mirrors/private_symbol_test.dart b/tests/lib/mirrors/private_symbol_test.dart
index 09d8261242ade37b453df661ef320a8cbef861d1..156381aa3b2da9daf52f6e9a447cb141a3614e82 100644
--- a/tests/lib/mirrors/private_symbol_test.dart
+++ b/tests/lib/mirrors/private_symbol_test.dart
@@ -29,15 +29,21 @@ main() {
Symbol corefoo = MirrorSystem.getSymbol('foo', libcore);
Symbol mathfoo = MirrorSystem.getSymbol('foo', libmath);
Symbol testfoo = MirrorSystem.getSymbol('foo', libtest);
+ Symbol nullfoo1 = MirrorSystem.getSymbol('foo');
+ Symbol nullfoo2 = MirrorSystem.getSymbol('foo', null);
Expect.equals(corefoo, mathfoo);
Expect.equals(mathfoo, testfoo);
Expect.equals(testfoo, corefoo);
+ Expect.equals(nullfoo1, corefoo);
+ Expect.equals(nullfoo2, corefoo);
Expect.equals('foo', MirrorSystem.getName(corefoo));
Expect.equals('foo', MirrorSystem.getName(mathfoo));
Expect.equals('foo', MirrorSystem.getName(testfoo));
Expect.equals('foo', MirrorSystem.getName(#foo));
+ Expect.equals('foo', MirrorSystem.getName(nullfoo1));
+ Expect.equals('foo', MirrorSystem.getName(nullfoo2));
Symbol core_foo = MirrorSystem.getSymbol('_foo', libcore);
Symbol math_foo = MirrorSystem.getSymbol('_foo', libmath);
« runtime/lib/mirrors_patch.dart ('K') | « runtime/lib/mirrors_patch.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698