src/math.js - Issue 61753011: Slight change to Math.sin approximation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/math.js

Issue 61753011: Slight change to Math.sin approximation. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/math.js

diff --git a/src/math.js b/src/math.js

index 385b3c2a221832bbe1d15cc268ed7ae2b6ac74e0..e1a6ae9e4b675a76857f74802a5e3e2fa4c7b45b 100644

--- a/src/math.js

+++ b/src/math.js

@@ -220,8 +220,9 @@ function SetupTrigonometricFunctions() {

var samples = 1800; // Table size.

var pi = 3.1415926535897932;

var pi_half = pi / 2;

- var inverse_pi_half = 1 / pi_half;

- var two_pi = pi * 2;

+ var inverse_pi_half = 2 / pi;

+ var two_pi = 2 * pi;

+ var four_pi = 4 * pi;

var interval = pi_half / samples;

var inverse_interval = samples / pi_half;

var table_sin;

@@ -252,6 +253,7 @@ function SetupTrigonometricFunctions() {

}

var MathSinInterpolation = function(x) {

+ if (x > four_pi) x -= four_pi;

Jakob Kummerow 2013/11/13 16:09:28 I think this needs a comment. Roughly: // Sunspid

var multiple = MathFloor(x * inverse_pi_half);

if (%_IsMinusZero(multiple)) return multiple;

x = (multiple & 1) * pi_half +

« no previous file with comments | « no previous file | no next file » | no next file with comments »