Remove SVGLocatable and SVGTransformable

Source/core/svg/SVGGraphicsElement.h

Index: Source/core/svg/SVGGraphicsElement.h
diff --git a/Source/core/svg/SVGGraphicsElement.h b/Source/core/svg/SVGGraphicsElement.h
index 1e208045d5db65f485818e26f15b16fcb11ebe15..fc5498c7090b04625d28f0c3c3bf0db6bec4a13b 100644
--- a/Source/core/svg/SVGGraphicsElement.h
+++ b/Source/core/svg/SVGGraphicsElement.h
@@ -24,23 +24,26 @@
 #include "core/svg/SVGAnimatedTransformList.h"
 #include "core/svg/SVGElement.h"
 #include "core/svg/SVGTests.h"
-#include "core/svg/SVGTransformable.h"
 
 namespace WebCore {
 
 class AffineTransform;
 class Path;
 
-class SVGGraphicsElement : public SVGElement, public SVGTransformable, public SVGTests {
+class SVGGraphicsElement : public SVGElement, public SVGTests {
 public:
     virtual ~SVGGraphicsElement();
 
-    virtual AffineTransform getCTM(StyleUpdateStrategy = AllowStyleUpdate);
-    virtual AffineTransform getScreenCTM(StyleUpdateStrategy = AllowStyleUpdate);
-    virtual SVGElement* nearestViewportElement() const;
-    virtual SVGElement* farthestViewportElement() const;
+    enum StyleUpdateStrategy { AllowStyleUpdate, DisallowStyleUpdate };
 
-    virtual AffineTransform localCoordinateSpaceTransform(SVGLocatable::CTMScope mode) const { return SVGTransformable::localCoordinateSpaceTransform(mode); }
+    AffineTransform getCTM(StyleUpdateStrategy = AllowStyleUpdate);
+    AffineTransform getScreenCTM(StyleUpdateStrategy = AllowStyleUpdate);
+    AffineTransform getTransformToElement(SVGElement*, ExceptionState&, StyleUpdateStrategy = AllowStyleUpdate);
+    SVGElement* nearestViewportElement() const;
+    SVGElement* farthestViewportElement() const;
+    static SVGElement* nearestViewportElement(const SVGElement*);

[pdr., 2013/11/11 00:02:09]

I still don't think this is necessary.

There are now four callers of this:
1) SVGGraphicsElement::nearestViewportElement() - replace with the static
version
2) RenderSVGModelObject::getElementCTM() - the only callers of this pass in an
SVGGraphicsElement. Lets just replace the generic SVGElement* parameters with
SVGGraphicsElement*.
3) SVGSVGElement::setupInitialView uses nearestViewportElement but then
immediately checks for isSVGElement. This can just be refactored to look for the
nearest SVG element.
4) SVGGraphicsElement::computeCTM() - replace SVGElement* parameter with
SVGGraphicsElement*.

+
+    virtual AffineTransform localCoordinateSpaceTransform(SVGElement::CTMScope) const { return animatedLocalTransform(); }

[pdr., 2013/11/11 00:02:09]

Please add OVERRIDE

virtual AffineTransform localCoordinateSpaceTransform(SVGElement::CTMScope)
const OVERRIDE { ... etc

     virtual AffineTransform animatedLocalTransform() const;
     virtual AffineTransform* supplementalTransform();