sdk/lib/io/http_parser.dart - Issue 61753003: Avoid throwing internal null-pointer exceptions in http parser.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/io/http_parser.dart

Issue 61753003: Avoid throwing internal null-pointer exceptions in http parser. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/io/http_parser.dart

diff --git a/sdk/lib/io/http_parser.dart b/sdk/lib/io/http_parser.dart

index 058bb670880450685e49341ee338282d788dcadb..498cd021f9c63fbae7e389d125c48053ac311b9e 100644

--- a/sdk/lib/io/http_parser.dart

+++ b/sdk/lib/io/http_parser.dart

@@ -210,9 +210,8 @@ class _HttpParser

_pauseStateChanged();

onCancel: () {

- try {

+ if (_socketSubscription != null) {

_socketSubscription.cancel();

- } catch (e) {

}

});

_reset();

« no previous file with comments | « no previous file | no next file » | no next file with comments »